Skip to content

docs(validate_dataset_schema): cite experiment.py analyze_unit() instead of drifting line numbers #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gadievron wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −2
Open

docs(validate_dataset_schema): cite experiment.py analyze_unit() instead of drifting line numbers #101

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions libs/openant-core/validate_dataset_schema.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ def validate_unit(unit, index):
if not unit.get("id"):
errors.append(f"Unit {index}: missing 'id'")

# 2. Check unit.code structure (experiment.py lines 186-196)
# 2. Check unit.code structure (built by experiment.py analyze_unit())
code_field = unit.get("code", {})
if not isinstance(code_field, dict):
errors.append(f"Unit {index}: 'code' must be dict, got {type(code_field)}")
Expand All @@ -43,7 +43,7 @@ def validate_unit(unit, index):
elif not isinstance(primary_origin.get(deps_inlined_key), bool):
errors.append(f"Unit {index}: 'code.primary_origin.deps_inlined' must be bool")

# 6. CRITICAL: Check files_included (experiment.py line 192)
# 6. CRITICAL: Check files_included (set by experiment.py analyze_unit())
if "files_included" not in primary_origin:
errors.append(f"Unit {index}: MISSING 'code.primary_origin.files_included'")
elif not isinstance(primary_origin.get("files_included"), list):
Expand Down
Loading