fix(openapi-mcp): avoid release adapter startup deadlock - #25
Merged
Adam Poulemanos (bashandbone) merged 1 commit intoSep 5, 2026
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Adam Poulemanos (bashandbone)
deleted the
fix/openapi-mcp-release-startup
branch
September 5, 2026 18:52
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix the startup deadlock that prevented the first regular OpenAPI MCP release from reaching OIDC verification.
The release entrypoint awaited semantic-release while registering that same module's file path as its npm plugin. The plugin loader then awaited the entrypoint's unfinished module evaluation, producing Node's unsettled top-level-await warning and exit code 13.
Register the existing guarded adapter object as an inline plugin instead. Preserve its options, exported hooks, token/OIDC guards, tested-tarball checks, single publication, and mandatory public verification.
Add a Node subprocess regression around entrypoint/plugin initialization, with publication side effects disabled and the real installed plugin loader retained.
Failure evidence: regular release attempt 2. Package checks passed; startup failed before OIDC verification or npm publication. npm still contained only
0.0.0when checked afterward.Plugin(s) affected
Verification
bun test: 1,004 passed, 1 existing Microsoft Graph test skipped, 0 failed; 4,907 assertions across 40 files.bun run validate: marketplace validation and generated-file checks passed.git diff --checkpassed.a799e39..2446f41: no critical, important, or minor findings. Reviewer independently reproduced the original Node exit 13 and verified the fixed startup/guard reachability. This verifies startup, not OIDC authentication or publication success.Release safety
OPENAPI_MCP_OIDC_READYremainsfalse. This PR does not publish, approve a deployment, change npm settings, or enable a release. After merge, the fixed source needs a separately authorized regular-release attempt; rerunning the old failing source will not apply this fix.Rollback: revert this PR with the release gate still disabled. Do not reintroduce a bootstrap token or republish
0.0.0.Checklist