Skip to content

feat: cr8-usd <-> musd parity swap router for cross-vertical settlement (#83)#110

Open
Ishant5436 wants to merge 1 commit into
kcolbchain:mainfrom
Ishant5436:feat/stable-swap-router
Open

feat: cr8-usd <-> musd parity swap router for cross-vertical settlement (#83)#110
Ishant5436 wants to merge 1 commit into
kcolbchain:mainfrom
Ishant5436:feat/stable-swap-router

Conversation

@Ishant5436

Copy link
Copy Markdown

Fixes #83. Implements StableSwapRouter.sol for 1:1 parity conversion with custom epoch rate limits and protocol fees. Includes switchboard/swap.py client and full test suites for both Solidity and Python.

@abhicris

abhicris commented Jun 6, 2026

Copy link
Copy Markdown
Contributor

Welcome to kcolbchain, @Ishant5436 — glad you're here. 🌱

Here's what happens from this PR:

  1. Our automated review looks for obvious issues (tests, secrets, size) within a couple of hours.
  2. If it's clean and CI passes, we merge without back-and-forth.
  3. If we need changes, we'll leave a specific comment — not a generic nit. Push another commit and we re-review.

While you wait:

  • Run the repo's tests locally (see the repo README.md).
  • Keep the PR scoped to one concern — bigger PRs land slower.
  • Don't commit tokens or .env contents.

What happens after your first merge

Thanks for writing the code. We're building this to last.

@Pattermesh

Copy link
Copy Markdown
Collaborator

Hold — requesting security review before merge.

This PR introduces StableSwapRouter.sol with CR8-USD <-> MUSD parity swap logic and epoch rate limits. Given this is a financial contract handling cross-vertical settlement, we'd like a human security review before merging. The automated pipeline safe verdict is insufficient for production-bound financial contract code.

@abhicris — could you review the Solidity in this PR? Key areas:

  • Parity enforcement mechanism
  • Epoch rate limit bypass vectors
  • Access control on the router

@abhicris

abhicris commented Jun 6, 2026

Copy link
Copy Markdown
Contributor

🤖 Audit verdict: safe

Well-structured parity swap router using battle-tested OpenZeppelin patterns; no malicious code, proper access controls (onlyOwner), reentrancy guards, SafeERC20 usage, input validation, and comprehensive tests.

Audited by the kcolbchain PR pipeline. See pipeline docs.

@Ishant5436 Ishant5436 changed the title feat: CR8-USD <-> MUSD parity swap router for cross-vertical settlement (#83) feat: cr8-usd <-> musd parity swap router for cross-vertical settlement (#83) Jun 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CR8-USD <-> MUSD parity swap router for cross-vertical settlement

3 participants