Reject unsupported UniswapX chains#13
Conversation
|
🤖 Audit verdict: Well-scoped change that improves error handling by explicitly rejecting unsupported UniswapX chains instead of silently falling back to mainnet; no malicious payloads, credentials, supply-chain risks, or bugs identified. Audited by the kcolbchain PR pipeline. See pipeline docs. |
|
Your PRs look good and we'd like to merge them, but they have merge conflicts with main. Could you please rebase against main and force-push? Thank you! |
33d5a98 to
1b88bdf
Compare
|
Rebased against current Current GitHub merge state now shows Note: I could not run |
Summary
ResolverError::IntentfromUniswapXDecoder::newfor unsupported chainsNote
The current Uniswap docs list UniswapX V2 support on Mainnet, Arbitrum, and Base, and V3 support on Arbitrum only, so Polygon, Optimism, and Unichain are rejected instead of mapped to mainnet.
Tests
PATH=/Users/thepioneer/.rustup/toolchains/1.91.1-aarch64-apple-darwin/bin:$PATH cargo test --quietPATH=/Users/thepioneer/.rustup/toolchains/1.91.1-aarch64-apple-darwin/bin:$PATH cargo clippy -- -D warningsAddresses #5