Skip to content

Add CoW Protocol intent decoder#12

Merged
abhicris merged 1 commit into
kcolbchain:mainfrom
bonginkan:codex/cow-protocol-decoder-4
Jun 7, 2026
Merged

Add CoW Protocol intent decoder#12
abhicris merged 1 commit into
kcolbchain:mainfrom
bonginkan:codex/cow-protocol-decoder-4

Conversation

@MyTH-zyxeon

Copy link
Copy Markdown
Contributor

Summary

  • adds a CoW Protocol auction decoder that normalizes orderbook auction orders into Intent values
  • maps CoW order fields into token in/out, sell amount, min buy amount, deadline, and receiver/owner recipient fallback
  • wires the decoder into the intent module and CLI protocol selector
  • adds an offline golden auction fixture with unit coverage

Validation

  • cargo test: 9 passed
  • cargo clippy --all-targets -- -D warnings

Closes #4

@abhicris

Copy link
Copy Markdown
Contributor

Welcome to kcolbchain, @MyTH-zyxeon — glad you're here. 🌱

Here's what happens from this PR:

  1. Our automated review looks for obvious issues (tests, secrets, size) within a couple of hours.
  2. If it's clean and CI passes, we merge without back-and-forth.
  3. If we need changes, we'll leave a specific comment — not a generic nit. Push another commit and we re-review.

While you wait:

  • Run the repo's tests locally (see the repo README.md).
  • Keep the PR scoped to one concern — bigger PRs land slower.
  • Don't commit tokens or .env contents.

What happens after your first merge

Thanks for writing the code. We're building this to last.

@abhicris

Copy link
Copy Markdown
Contributor

🤖 Audit verdict: safe

Straightforward intent decoder implementation with proper error handling, tests, and no security red flags; follows established patterns in the codebase.

Audited by the kcolbchain PR pipeline. See pipeline docs.

@Pattermesh

Copy link
Copy Markdown

Your PRs look good and we'd like to merge them, but they have merge conflicts with main. Could you please rebase against main and force-push? Thank you!

@MyTH-zyxeon MyTH-zyxeon force-pushed the codex/cow-protocol-decoder-4 branch from 7e636d1 to 2ace840 Compare June 6, 2026 12:04
@MyTH-zyxeon

Copy link
Copy Markdown
Contributor Author

Rebased against current main and force-pushed the PR branch.

Current GitHub merge state now shows mergeable=MERGEABLE / mergeStateStatus=UNSTABLE instead of the prior conflict state. I resolved the src/main.rs conflict by keeping the current chain list and adding the CoW protocol decoder option in the newer Result<Box<dyn IntentDecoder>> shape.

Note: I could not run cargo fmt / cargo test in this local Codex environment because cargo is not available on PATH here.

@abhicris abhicris merged commit 93d9329 into kcolbchain:main Jun 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[good first issue] Add CoW Protocol v2 intent decoder (similar to Across)

3 participants