Skip to content

Games Service bug #265

Description

@YuvalOvadia1

The functions findAllGamesByField, findPendingGamesByField and findApprovedGamesByField in game service will not return the expected exceptions.

using a typeORM's find() returns a empty array when founds nothing, and empty array is a truthy value in JS.

we need to throw the exception when the array is empty.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions