The parts that are common between the NIRSPec IFU and MIRI MRS implementations should not be duplicated in two files.
After the PR #44 we want a separate PR to combine and streamline the shared pieces, as discussed by @AlexBidot @mperrin and @jruffio.
Comments saved from the PR #44 discussion which are relevant for this:
- Move build cubes to a utils file since common to MIRI and NIRSpec (Might keep this for a future upgrade), could also merge some of the code between MIRI and NIRSpec.
- Zerr_masking <5e1 had to be removed for MIRI, but need to check why it was there in the first place, otherwise there is a risk we might break NIRSpec reductions too.
The parts that are common between the NIRSPec IFU and MIRI MRS implementations should not be duplicated in two files.
After the PR #44 we want a separate PR to combine and streamline the shared pieces, as discussed by @AlexBidot @mperrin and @jruffio.
Comments saved from the PR #44 discussion which are relevant for this: