From e6c3bc168e2381fedf485da39c692346675b1d46 Mon Sep 17 00:00:00 2001
From: Cursor Agent <cursoragent@cursor.com>
Date: Tue, 14 Apr 2026 17:32:41 +0000
Subject: [PATCH] Allow publishing existing bookmarks from edit modal
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Co-authored-by: Jérôme Gangneux <jrmgx@users.noreply.github.com>
---
 .../components/EditBookmark/EditBookmark.tsx  | 22 ++++++++++++---
 .../Api/Controller/MeBookmarkController.php   |  6 +++++
 server/tests/Api/Controller/BookmarkTest.php  | 27 +++++++++++++++++++
 3 files changed, 52 insertions(+), 3 deletions(-)

diff --git a/client/src/components/EditBookmark/EditBookmark.tsx b/client/src/components/EditBookmark/EditBookmark.tsx
index 397d95f..0372cc3 100644
--- a/client/src/components/EditBookmark/EditBookmark.tsx
+++ b/client/src/components/EditBookmark/EditBookmark.tsx
@@ -12,6 +12,7 @@ interface EditBookmarkProps {
 export const EditBookmark = ({ bookmark, onSave, onClose }: EditBookmarkProps) => {
   const modalRef = useRef<HTMLDivElement>(null);
   const [title, setTitle] = useState('');
+  const [isPublic, setIsPublic] = useState(false);
   const [isSaving, setIsSaving] = useState(false);
   const [saveError, setSaveError] = useState<string | null>(null);
   const [saveErrorStatus, setSaveErrorStatus] = useState<number | null>(null);
@@ -37,6 +38,7 @@ export const EditBookmark = ({ bookmark, onSave, onClose }: EditBookmarkProps) =
     setSaveErrorStatus(null);
     if (bookmark) {
       setTitle(bookmark.title);
+      setIsPublic(bookmark.isPublic);
     }
     onClose();
   }, [bookmark, onClose]);
@@ -45,8 +47,9 @@ export const EditBookmark = ({ bookmark, onSave, onClose }: EditBookmarkProps) =
   useEffect(() => {
     if (bookmark) {
       setTitle(bookmark.title);
+      setIsPublic(bookmark.isPublic);
     }
-  }, [bookmark?.title]);
+  }, [bookmark?.title, bookmark?.isPublic]);
 
   // Show modal when bookmark changes
   useEffect(() => {
@@ -82,7 +85,7 @@ export const EditBookmark = ({ bookmark, onSave, onClose }: EditBookmarkProps) =
 
     try {
       // Update bookmark title via API
-      const updatedBookmark = await updateBookmark(bookmark.id, { title: title.trim() });
+      const updatedBookmark = await updateBookmark(bookmark.id, { title: title.trim(), isPublic });
 
       // Dispatch custom events to notify other components
       // Pass the updated bookmark in the event detail to avoid full page reload
@@ -139,6 +142,19 @@ export const EditBookmark = ({ bookmark, onSave, onClose }: EditBookmarkProps) =
                   autoFocus
                 />
               </div>
+              <div className="form-check">
+                <input
+                  className="form-check-input"
+                  type="checkbox"
+                  id="bookmark-is-public-input"
+                  checked={isPublic}
+                  onChange={(e) => setIsPublic(e.target.checked)}
+                  disabled={isSaving}
+                />
+                <label className="form-check-label" htmlFor="bookmark-is-public-input">
+                  Public
+                </label>
+              </div>
             </div>
             <div className="modal-footer">
               <button
@@ -152,7 +168,7 @@ export const EditBookmark = ({ bookmark, onSave, onClose }: EditBookmarkProps) =
               <button
                 type="submit"
                 className="btn btn-primary"
-                disabled={isSaving || !title.trim() || (bookmark ? title.trim() === bookmark.title : false)}
+                disabled={isSaving || !title.trim() || (bookmark ? (title.trim() === bookmark.title && isPublic === bookmark.isPublic) : false)}
               >
                 {isSaving ? (
                   <>
diff --git a/server/src/Api/Controller/MeBookmarkController.php b/server/src/Api/Controller/MeBookmarkController.php
index bc71680..430c105 100644
--- a/server/src/Api/Controller/MeBookmarkController.php
+++ b/server/src/Api/Controller/MeBookmarkController.php
@@ -436,6 +436,8 @@ public function patch(
         )]
         BookmarkApiDto $bookmarkPayload,
     ): JsonResponse {
+        $wasPublic = $bookmark->isPublic;
+
         // Manual merge
         if (isset($bookmarkPayload->title)) {
             $bookmark->title = $bookmarkPayload->title;
@@ -461,6 +463,10 @@ public function patch(
             $this->entityManager->persist($indexAction);
 
             $this->entityManager->flush();
+
+            if (!$wasPublic && $bookmark->isPublic) {
+                $this->messageBus->dispatch(new SendCreateNoteMessage($bookmark->id));
+            }
         } catch (ORMInvalidArgumentException|ORMException $e) {
             throw new UnprocessableEntityHttpException(previous: $e);
         }
diff --git a/server/tests/Api/Controller/BookmarkTest.php b/server/tests/Api/Controller/BookmarkTest.php
index 03507c2..ea65470 100644
--- a/server/tests/Api/Controller/BookmarkTest.php
+++ b/server/tests/Api/Controller/BookmarkTest.php
@@ -555,6 +555,33 @@ public function testEditBookmarkTagsOnly(): void
         $this->assertCount(0, $json['tags'], 'All tags should be removed');
     }
 
+    public function testEditOwnBookmarkCanToggleVisibilityToPublic(): void
+    {
+        [, $token, $account] = $this->createAuthenticatedUserAccount('testuser', 'test');
+
+        $bookmark = BookmarkFactory::createOne([
+            'account' => $account,
+            'title' => 'Private Bookmark',
+            'url' => 'https://example.com/private',
+            'isPublic' => false,
+        ]);
+
+        $this->request('PATCH', "/users/me/bookmarks/{$bookmark->id}", [
+            'headers' => ['Content-Type' => 'application/json'],
+            'auth_bearer' => $token,
+            'json' => [
+                'isPublic' => true,
+            ],
+        ]);
+        $this->assertResponseIsSuccessful();
+
+        $json = $this->dump($this->getResponseArray());
+        $this->assertTrue($json['isPublic'], 'Bookmark should become public after PATCH update.');
+
+        $this->request('GET', "/profile/testuser/bookmarks/{$bookmark->id}");
+        $this->assertResponseIsSuccessful();
+    }
+
     public function testDeleteOwnBookmark(): void
     {
         [, $token, $account] = $this->createAuthenticatedUserAccount('testuser', 'test');