Skip to content

Invalid DOM property fill-rule in Icons component  #20

Description

@CezarLuca

I encountered a warning in the console when using the UNDERLINE from COPY_PASTE_LIST.md from this repository:

Warning: Invalid DOM property fill-rule. Did you mean fillRule?

The code from the Icons.tsx in the underline icon component on the other hand is correct.
I propose to change fill-rule to fillRule in COPY_PASTE_LIST.md to be correct and consistent with the production code and eliminate the debugging step for those who code along:

<svg {...props} viewBox='0 0 687 155'>
  <g
    stroke='currentColor'
    strokeWidth='7'
    fill='none'
    fillRule='evenodd'
    strokeLinecap='round'
    strokeLinejoin='round'>
    <path
      d='M20 98c27-13.3333333 54-20 81-20 40.5 0 40.5 20 81 20s40.626917-20 81-20 40.123083 20 80.5 20 40.5-20 81-20 40.5 20 81 20 40.626917-20 81-20c26.915389 0 53.748722 6.6666667 80.5 20'
      opacity='.3'></path>
    <path d='M20 118c27-13.3333333 54-20 81-20 40.5 0 40.5 20 81 20s40.626917-20 81-20 40.123083 20 80.5 20 40.5-20 81-20 40.5 20 81 20 40.626917-20 81-20c26.915389 0 53.748722 6.6666667 80.5 20'></path>
  </g>
</svg>```

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions