Replies: 7 comments 1 reply
|
Take refactoring gpt-oss replacement as an example a4a4118 |
0 replies
|
Need is somehow general, especially for MoE related models. let's include more people in review @wenhuach21, @n1ck-guo, @WeiweiZhang1, @mengniwang95, @xinhe3. Pls give your feedback so that we can move to next step, like raising PR |
0 replies
|
Consider adding a function to verify the model's configuration or related information. Relying solely on the module name may not provide sufficient robustness. |
0 replies
|
We also need to consider how to apply this in AutoRound inference on the Transformers backend, where the replacement must occur before loading the weights. But we could assume that the wights is aligned to the replaced module |
1 reply
|
Looks good to me. |
0 replies
|
LGTM |
0 replies
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Design for #899
Usage
@wenhuach21 @n1ck-guo Please help review that design, thx.
cc @thuang6
All reactions