ci: use Node 22 for shell E2E - #730
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ytallo
added
the
no-ticket
6f75c6c
into
feat/console/tabs-and-redesign-merge-main
skill-check — worker0 verified, 55 skipped (no docs/).
Four for four. Nicely done. |
* feat(console): tabs and console redesign * feat: shell ui and ui redesign * fix(ci): install pnpm in the shell E2E workflow shell/build.rs now builds the injectable UI (shell/ui) with pnpm before embedding its assets; the E2E workflow only set up Node, so the cargo build panicked with "pnpm not found on PATH". Same pnpm/action-setup pattern ci.yml uses for Rust workers with a ui/ directory — the version comes from the repo-root package.json packageManager field. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * ci: use Node 22 for shell E2E (#730) --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com> Co-authored-by: Ytallo <ytallo.layon@gmail.com>
1 participant
What changed
pnpm@11.13.1toolchainRoot cause
The workflow installed Node.js 20 before resolving pnpm from the root
packageManagerfield. pnpm 11 requires Node.js 22.13 or newer and failed while importingnode:sqlite, causing the Shell UI build to panic before either Harness mode could run.Impact
The default and jailed Shell Harness jobs can install the UI dependencies and proceed to the actual E2E scenarios.
Validation
git diff --check.github/workflows/shell-e2e.yml