Issue in gusb/meson.build

[CTerasaGuF]

Is this endif safe? Shouldn't it be after the vapi if-block?

libgusb/gusb/meson.build

Line 180 in a6f0cba

endif

The libgusb_girtarget is not set if introspection is not enabled but vapi is

Using a Yocto build with 636efc0 where this is included:

libgusb/gusb/meson.build

Line 125 in 636efc0

endif

I get the following error (snipped away some dirs):

Build started at 2020-09-17T16:05:20.241926
Main binary: /<snip>/usr/bin/nativepython3
Build Options: -Ddocs=false -Dintrospection=false -Dprefix=/usr -Dbindir=bin -Ddatadir=share -Dincludedir=include -Dinfodir=share/info -Dlibdir=lib -Dlibexecdir=libexec -Dlocalstatedir=/var -Dmandir=share/man -Dsbindir=sbin -Dsharedstate
dir=/com -Dsysconfdir=/etc -Dbuildtype=plain -Dwrap_mode=nodownload '--cross-file //<snip>/meson.cross'
Python system: Linux
The Meson build system
Version: 0.53.2
Source dir: /<snip>/git
Build dir: /<snip>/build
Build type: cross build
Project name: libgusb
Project version: 0.3.1
No CFLAGS in the environment, not changing global flags.
No LDFLAGS in the environment, not changing global flags.
No CPPFLAGS in the environment, not changing global flags.
Sanity testing C compiler: gcc
Is cross compiler: False.
Sanity check compiler command line: gcc //<snip>/meson-private/sanitycheckc.c -o /<snip>/meson-private/sanitycheckc.exe -pipe -D_FILE_OFFSET_BITS=64
 ...
Compiler stderr:

Run-time dependency gio-2.0 found: YES 2.62.4
Pkg-config binary for MachineChoice.HOST is cached.
Determining dependency 'libusb-1.0' with pkg-config executable '/<snip>/usr/bin/pkg-config'
PKG_CONFIG_PATH: ...
Run-time dependency libusb-1.0 found: YES 1.0.22
Configuring config.h using configuration
Configuring gusb-version.h using configuration

gusb/meson.build:128:6: ERROR: Unknown variable "libgusb_girtarget".```

[hughsie]

We can't build the vapi without introspection. We should probably add some kind of error() in the top level meson.build if the user tries to do this.

[CTerasaGuF]

Yes, we could error() if a user builds vapi without introspection, pull the vapi block into the introspection block so it won't be used if introspection is not used, or do both.

But as I do not know how to use the meson build system and I do not know libgusb, I do not feel qualified to do the change myself.