GUIHelper toggle indicator not displaying

[lucianposton]

KingmakerModMaker/ModMaker/Utility/GUIHelper.cs

Lines 11 to 12 in 3b78d09

	public static string FormatOn = "◑".Color(RGBA.lime) + " - {0}";
	public static string FormatOff = "◐".Color(RGBA.red) + " - {0}";

The ◑/etc in the above is not appearing in Pathfinder Kingmaker (the linux port). My guess is that the fonts loaded by the process don't have glyphs for these code points.

My system has fonts with glyphs for these code points, but I'm not that familiar with how unity loads fonts.

Any thoughts on how to address this issue? I'm not sure where the responsibility of loading fonts lies. Is it in the unity engine, mod manager, your code, some font library used by unity engine, some system font library used by mono on linux / .NET on windows?

[lucianposton]

[lucianposton]

This issue is indeed a missing glyph from whatever fonts are loaded by unity (or mono, whatever is responsible for loading fonts here).

I verified it by replacing ◑/◐ with Y/N, and it behaves as expected:

I wonder if this might be a cross-platform parity issue in unity (or perhaps mono).

Here are some ideas for how to resolve this issue.

1. Change the code point to something more widely available e.g. Y/N. Could also use another/additional indicator.
2. If the font can be configured by the user (e.g. via system font priorities), we could simply leave this issue as is. The consequence is some users will encounter this issue and be confused and/or ask for help, to which the response is to configure his fonts to select a font containing glyphs for these code points. This would be a worse user experience.

[lucianposton]

I noticed that the Craft Magical Items mod's toggle indicators were working properly, so I thought I'd look how it implemented the indicators, and then send a PR here to do something similar. Here is the Craft Magical Items mod's code:

            if (GUILayout.Button($"{(value ? "<color=green><b>✔</b></color>" : "<color=red><b>✖</b></color>")} {label}", GUILayout.ExpandWidth(false))) {

I tried replacing ◑/◐ with ✔/✖, but those characters had the exact same rendering issue as ◑/◐ -- they wouldn't render at all. So why were the indicators working in that mod, but not in KindmakerModMaker?

Strangely, it has to do with the bold tags <b> around those characters. Making any of these 4 characters bold makes them appear in the GUI button! I tried a number of different variations (no color and no bold, no color and bold, etc), and it seems that the glyphs for these code points only render when they are bold. Here is a PR #13 .

I don't know exactly what the underlying issue is. The bold versions of these glyphs work on linux, but not the non-bold ones. Is that due to an issue in the font used by the game (does the game package its own font? or does it use unity's?), or is it an issue in mono's font rendering? I don't know, but my best guess is the issue is somewhere in unity or mono.