Package / pyproject.toml#22
Open
dweindl wants to merge 6 commits into
Open
Conversation
dweindl
force-pushed
the
pyproject
branch
2 times, most recently
from
19daa3b to
102d071
Compare
The default reference database directory is currently inside the installation directory. This may not always be writable. Thus, allow specifying a custom directory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create a proper Python package. Simplifies installation (e.g., currently via
pip install git+https://github.com/dweindl/ComplexFinder.git@pyproject) and will allow deploying the package to PyPI.pyproject.tomlreference-data/to include it in the package.Not sure it belongs into the package or if users should just download their own reference files. For now, I included it. Minor issue: The database file is written to that directory after filtering. Ideally, Python packages shouldn't modify their installation directory after installation (and it may not always be writable). For that I added an additional
databaseDiroption to allow users choose a custom directory for looking up and caching those files.Python package names are usually all lower case, so I went for
complexfinder. Feel free to choose any other name.Also feel free update any other package metadata.