Add Windows support#9
Open
leiflm wants to merge 3 commits into
Open
Conversation
added 2 commits
May 18, 2021 10:15
According to upstream documentation[0] Windows(TM) is not supported automatically. But one can use a drop-in replacement for `pexpect.spawn` in the case of fd based approaches.
According to upstream documentation[0], at least version 4.0 is required for Windows support. [0] https://pexpect.readthedocs.io/en/stable/overview.html#pexpect-on-windows
leiflm
commented
May 18, 2021
Comment on lines
+26
to
+27
| import os | ||
| if os.name in ['nt']: |
Author
There was a problem hiding this comment.
AFAICT this condition is not even necessary. Using pexpect.fdexpect.fdspawn should be the right choice on any operating system.
To keep it "as is" as much as possible though, I've added this if/else conditional import statement here. Feel free to remove it and go solely with pexpect.fdexpect.fdspawn.
Windows support has been added. As this change is backwards compatible, bump only minor version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds Windows support by using a drop-in class replacement for
pexpect.spawn, introduced by pexpect 4.0.