Skip to content

Make client logging best-effort #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yuenler wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Make client logging best-effort #58

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
281070f
Make client logging best-effort
yuenler May 31, 2026
253578c
didnt need any
yuenler May 31, 2026
d274367
log instead
yuenler May 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
111 changes: 58 additions & 53 deletions src/helpers/logClientEvent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,59 +66,64 @@ const logClientEvent: LogFunction = async (opts) => {
}
}

// Send to server
return visitServerEndpoint({
path: LOG_ROUTE_PATH,
method: 'POST',
params: {
context: (
typeof opts.context === 'string'
? opts.context
: (
((opts.context as any) ?? {})._
?? LogBuiltInMetadata.Context.Uncategorized
)
),
subcontext: (
opts.subcontext
?? LogBuiltInMetadata.Context.Uncategorized
),
level: (
opts.level
?? LogLevel.Info
),
tags: JSON.stringify(opts.tags ?? []),
metadata: JSON.stringify(metadata),
errorMessage: (
(opts as any).error
? (opts as any).error.message
: undefined
),
errorCode: (
(opts as any).error
? (opts as any).error.code
: undefined
),
errorStack: (
(opts as any).error
? (opts as any).error.stack
: undefined
),
target: (
(opts as any).action
? (
(opts as any).target
?? LogBuiltInMetadata.Target.NoTarget
)
: undefined
),
action: (
(opts as any).action
? (opts as any).action
: undefined
),
},
});
try {
return await visitServerEndpoint({
path: LOG_ROUTE_PATH,
method: 'POST',
params: {
context: (
typeof opts.context === 'string'
? opts.context
: (
((opts.context as any) ?? {})._
?? LogBuiltInMetadata.Context.Uncategorized
)
),
subcontext: (
opts.subcontext
?? LogBuiltInMetadata.Context.Uncategorized
),
level: (
opts.level
?? LogLevel.Info
),
tags: JSON.stringify(opts.tags ?? []),
metadata: JSON.stringify(metadata),
errorMessage: (
(opts as any).error
? (opts as any).error.message
: undefined
),
errorCode: (
(opts as any).error
? (opts as any).error.code
: undefined
),
errorStack: (
(opts as any).error
? (opts as any).error.stack
: undefined
),
target: (
(opts as any).action
? (
(opts as any).target
?? LogBuiltInMetadata.Target.NoTarget
)
: undefined
),
action: (
(opts as any).action
? (opts as any).action
: undefined
),
},
});
} catch (err) {
// Logging is best-effort. Keep the signal without breaking the user flow.
// eslint-disable-next-line no-console
console.warn('Failed to log client event', err);
}
};

export default logClientEvent;