gulp 5.0.1 mangling streams?

[angusmci]

I have a small convenience library that I use for creating responsive images. It uses through2, with sharp to do the actual conversion. I'm running on node v25.8.1 on MacOS X.

This runs without problems under gulp 4.0.2. However, if I switch to gulp 5.0.1, calling sharp on file.contents (where file is a Vinyl stream) fails with sharp reporting "Input buffer contains unsupported image format".

I dumped out the contents of the buffer, and it is indeed not a valid image. The JPEG header had been trashed, and the rest of the file partly overwritten with garbage data. The file had also bloated to almost twice its previous size.

The problem is definitely caused by the migration from gulp 4.x to 5.x; that's the only difference between the version that works and the one that doesn't.

I suspect that if gulp 5.x were routinely mangling Vinyl streams then someone would probably have said something by now, so it must be that something about my code that was safe to do under 4.x is no longer possible under 5.x. Can anyone suggest what might have happened, and how I can fix this to work with 5.x? Thanks.

const resizeImageJpg = (configuration) => {
  return new Promise((resolve, reject) => {
    try {
      configuration.versions.forEach(function (version) {
        gulp
          .src(configuration.source + "/**/*.jpg")
          .pipe(
            through2.obj(async function (file, _, cb) {
              let metadata = await sharp(file.contents).metadata();
              let width = Math.floor((metadata.width * version.percent) / 100);
              let converted = sharp(file.contents)
                .withMetadata()
                .resize({ width: width })
                .jpeg({
                  quality: Math.floor(version.quality.jpg * 100),
                  mozjpeg: true,
                })
                .toBuffer();
              return converted
                .then(function (buffer) {
                  file.contents = buffer;
                  return cb(null, file);
                })
                .catch(function (err) {
                  console.error(err);
                  return cb(null, file);
                });
            })
          )
          .pipe(
            rename(function (path) {
              path.extname = version.suffix + ".jpg";
            })
          )
          .pipe(gulp.dest(configuration.dest));
      });
      resolve(true);
    } catch (error) {
      reject(error);
    }
  });
};

[pioug]

If I recall correctly, you need encoding: false https://gulpjs.com/docs/en/api/src/#options in Gulp 5

gulp.src(configuration.source + "/**/*.jpg", { encoding: false })