Escape characters

[Csag-parel]

Hello,

We encountered an issue with escape characters when processing payments for Bulgaria through GoPay. After contacting GoPay support, we were informed that the presence of escape characters causes their system to treat the request as a potential threat, which leads to it being rejected.
To resolve this, could you please add functionality to specify the JSON_FLAG parameter in the json_encode() function used in the encodeData() method in gopay-php-api/src/GoPay.php?

Thank you for your assistance.

[gopayprovoz]

Hello,

please make sure you use UTF-8 encoding for all incoming and outgoing communication.

If you are using UTF-8 encoding and an error occurs, please specify for which e-shop (EVC, GoID) exactly
when the error occurs, send samples (screens, log with errors).

[Csag-parel]

ticket in your technical support [TT:12243911]
this ticket is in email communication

[gopayprovoz]

Hello,

I'm sorry, but unless you use UTF-8 encoding for all API communication, you can't avoid incorrect escaping by the gateway.

This cannot be influenced by the gateway.

[Csag-parel]

Hello,
we are using UTF-8 encoding but json_encode in default setting this characters escapes

[Csag-parel]

Hello,
I did another check to prove my claim that the texts for gopay are in UTF-8. Below you have the code I used. There is both a test of Czech characters and the data that we send to the gopay api without information about the customer. It is demonstrated here that the character encoding is in UTF-8 and json_encode is still escape. That is why a fork of your SDK for php has been created https://github.com/Csag-parel/gopay-php-api but we would be happy if you fixed it in your official SDK.
Thank you

CODE:

var_dump(json_encode(['testCZ' => 'ěščřžýáíé']));
        var_dump(mb_detect_encoding('ěščřžýáíé'));
        var_dump($normalizedPayment);
        foreach ($normalizedPayment['items'] as $key => $value) {
            var_dump($key);
            var_dump($value['name']);
            var_dump(mb_detect_encoding($value['name']));
        }
        var_dump(json_encode($normalizedPayment));
        die();

OUTPUT:

TEST CZ chars :
string(67) "{"testCZ":"\u011b\u0161\u010d\u0159\u017e\u00fd\u00e1\u00ed\u00e9"}"
string(5) "UTF-8"
        
array(9) {
  ["payer"]=>array(4) {
    ["allowed_payment_instruments"]=>array(1) {
    [0]=>string(12) "PAYMENT_CARD"
    }
    ["default_payment_instrument"]=>string(12) "PAYMENT_CARD"
    ["allowed_swifts"]=>array(0) {}
    ["contact"]=>array(8) {}
    ["target"]=>array(2) {
      ["type"]=>string(7) "ACCOUNT"
      ["goid"]=>int(0)
    }
  }
  ["items"]=> array(3) {
    [0]=>array(5) {
      ["type"]=>string(4) "ITEM"
      ["name"]=>string(43) "Оранжева basic тениска ORSAY"
      ["amount"]=>int(879)
      ["count"]=>int(1)
      ["ean"]=>int(4058583688241)
    }
    [1]=> array(3) {
      ["type"]=>string(8) "DELIVERY"
      ["name"]=>string(44) "СЛИВЕН - РЕЧИЦА (АВТОМАТ)"
      ["amount"]=>int(999)
    }
    [2]=>array(3) {
      ["type"]=>string(8) "DISCOUNT"
      ["name"]=>string(18) "Намаление"
      ["amount"]=>int(220)
    }
  }
  ["callback"]=>array(2) {
    ["return_url"]=>string(48) "http://localhost:3000/koshhnitsa/gopay-vrashtane"
    ["notification_url"]=>string(50) "http://localhost:3000/koshhnitsa/gopay-uvedomlenie"
  }
  ["amount"]=>int(1878)
  ["currency"]=>string(3) "BGN"
  ["order_number"]=>string(10) "1000000004"
  ["order_description"]=>string(29) "Поръчка № 1000000004"
  ["lang"]=>string(2) "BG"
}
ITEMS : NAME and ENCODING
int(0)
string(43) "Оранжева basic тениска ORSAY"
string(5) "UTF-8"
        
int(1)
string(44) "СЛИВЕН - РЕЧИЦА (АВТОМАТ)"
string(5) "UTF-8"
        
int(2)
string(18) "Намаление"
string(5) "UTF-8"
        
JSON :
{
  "payer": {
    "allowed_payment_instruments": [
      "PAYMENT_CARD"
    ],
    "default_payment_instrument": "PAYMENT_CARD",
    "allowed_swifts": [],
  },
  "target": {
    "type": "ACCOUNT",
    "goid": 0
  },
  "items": [
    {
      "type": "ITEM",
      "name": "\u041e\u0440\u0430\u043d\u0436\u0435\u0432\u0430 basic \u0442\u0435\u043d\u0438\u0441\u043a\u0430 ORSAY",
      "amount": 879,
      "count": 1,
      "ean": 4058583688241
    },
    {
      "type": "DELIVERY",
      "name": "\u0421\u041b\u0418\u0412\u0415\u041d - \u0420\u0415\u0427\u0418\u0426\u0410 (\u0410\u0412\u0422\u041e\u041c\u0410\u0422)",
      "amount": 999
    },
    {
      "type": "DISCOUNT",
      "name": "\u041d\u0430\u043c\u0430\u043b\u0435\u043d\u0438\u0435",
      "amount": 220
    }
  ],
  "callback": {
    "return_url": "http:\/\/localhost:3000\/koshhnitsa\/gopay-vrashtane",
    "notification_url": "http:\/\/localhost:3000\/koshhnitsa\/gopay-uvedomlenie"
  },
  "amount": 1878,
  "currency": "BGN",
  "order_number": "1000000004",
  "order_description": "\u041f\u043e\u0440\u044a\u0447\u043a\u0430\u2116 1000000004",
  "lang": "BG"
}

[gopayprovoz]

Hello,

thank you for the additional information, we are looking into the situation.

We will update you as soon as we have new information.

[pinochico]

Hello Gopay

so have you updated your API?

My ticket is TT:13050023 and I have the same problem.

So if you don't know how, pls change your function and add param for unescaped unicode

CODE:

private function encodeData($contentType, $data)

{
	if ($data) {
		if ($contentType === GoPay::FORM) {
			return http_build_query($data, "", '&');
		}
		return json_encode($data , JSON_UNESCAPED_UNICODE);
	}
	return '';
}

We fixed in our plugin Gopay Payment REST API now self.

Thanks

[gopayprovoz]

Hello,

I am sorry, but we do not have any information about this situation yet. We will let you know as soon as we have new information.

However, I would like to point out that in TT:13050023, it was told that an outdated version of PHP 7.4 is being used, but our documentation states that the minimum version must be 8.1.
We do not modify libraries for older versions, and using older versions of PHP may not take into account all functionalities.

[pinochico]

Hello,

Please do not mix unrelated issues.
The PHP version is irrelevant to the functionality of the PHP json_encode function.

https://www.php.net/manual/en/function.json-encode.php
(PHP 5 >= 5.2.0, PHP 7, PHP 8, PECL json >= 1.2.0)

Let's focus on solving the problem instead.

The problem is that the json_encode function creates an error that should be fixed (since you are not allowed to have escaped UTF-8 characters on your servers when receiving payment information).
Someone has already written about this here, and it is surprising that the plugin has been working for us for 10 years and suddenly there is an error.

But if you don't want to deal with it and you insist on using some version of PHP 8.1, that's fine, it doesn't bother me.
I'll just declare your API faulty and explain to anyone who asks why they have to upgrade plugins and why they have to pay for it, and I'll make the fix directly in the plugin in the attached Gopay API library. Nothing could be simpler :)

[gopayprovoz]

Hello,

We apologize, but the payment gateway does not currently have the ability to handle these cases, which may occasionally occur.
We will strive to improve this in our libraries in the future.
However, I do not have any new information at this time.

Yes, I can recommend modifying your plugin to prevent character escaping.

[pinochico]

Hello,

I understand.

Just so you understand correctly:

I am not modifying our plugin, but your API, which I load into the plugin.

So it's a typical Czech situation - we call it Kocourkov.

You don't modify your API, but I have to modify it after installing it from your Git, and that's only so that your server doesn't reject the data generated by your API for security reasons.

I think it's just a funny story, and I'm looking forward to Saturday's trip to Prague, where I'll see the Oscar that Czech director Mr. Menzel won.

I agree, I'll modify the plugin and advise others to do the same. Everything will be fine :)