From bad8c0d2023c584b0944e96c7aebc843fd2b6595 Mon Sep 17 00:00:00 2001
From: ensonic <ensonic@google.com>
Date: Tue, 19 May 2026 13:00:54 +0000
Subject: [PATCH] Move sync namespace check to helper.

This will let us add extra namespaces as needed.
See PR #676
---
 src/go/pkg/synk/synk.go | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)

diff --git a/src/go/pkg/synk/synk.go b/src/go/pkg/synk/synk.go
index 5aaa6f0b..fd131e4b 100644
--- a/src/go/pkg/synk/synk.go
+++ b/src/go/pkg/synk/synk.go
@@ -23,6 +23,7 @@ import (
 	"log/slog"
 	"reflect"
 	"regexp"
+	"slices"
 	"sort"
 	"strconv"
 	"strings"
@@ -410,6 +411,15 @@ func (s *Synk) applyAll(
 	return results, err
 }
 
+func validateNamespace(r *unstructured.Unstructured, optsNs string) error {
+	ns := r.GetNamespace()
+	allowed := []string{"", "kube-system", optsNs}
+	if slices.Contains(allowed, ns) {
+		return nil
+	}
+	return errors.Errorf("invalid namespace %q on %q, expected one of %v", ns, resourceKey(r), allowed)
+}
+
 // initialize a new ResourceSet version for the given name and prepare resources
 // for it.
 func (s *Synk) initialize(
@@ -432,8 +442,8 @@ func (s *Synk) initialize(
 	// so we can give validation errors in batch in the ResourceSet status.
 	if opts.EnforceNamespace {
 		for _, r := range regulars {
-			if ns := r.GetNamespace(); ns != "" && ns != opts.Namespace && ns != "kube-system" {
-				return nil, nil, errors.Errorf("invalid namespace %q on %q, expected %q or \"kube-system\"", ns, resourceKey(r), opts.Namespace)
+			if err := validateNamespace(r, opts.Namespace); err != nil {
+				return nil, nil, err
 			}
 		}
 	}