Skip to content

dev: Ensure Ads and Common Protos new component parameters are derived correctly #9387

Description

@bshaffer

We have a command which builds new components from proto files and calculates their parameters based on the protos provided:

./dev/google-cloud component:new

However, when a component has the namespace Google\Ads, custom parameters must be provided in order to configure the appropriate composer package name and github repository:

  • The composer package name should use googleapis as the vendor instead of google, e.g. googleads/[project-name] instead of google/[project-name]
  • The github repo should be googleapis/php-ads-[project-name]

The same is true for CommonProtos libraries - if no GAPIC clients exist, we append CommonProtos to the component name, and -common-protos to the package and repo names.

See go/cloud-sdk-php-new-component-heuristics

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions