From 72a48459506a2d570d9e07793c4bd215a2a9bc54 Mon Sep 17 00:00:00 2001 From: Jonathan Tatum Date: Tue, 14 Apr 2026 16:01:02 -0700 Subject: [PATCH] Remove special error for null select target. Just return the general invalid select target error. PiperOrigin-RevId: 899816955 --- eval/eval/select_step.cc | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/eval/eval/select_step.cc b/eval/eval/select_step.cc index b95915145..420f3ac31 100644 --- a/eval/eval/select_step.cc +++ b/eval/eval/select_step.cc @@ -19,7 +19,6 @@ #include "eval/eval/direct_expression_step.h" #include "eval/eval/evaluator_core.h" #include "eval/eval/expression_step_base.h" -#include "eval/internal/errors.h" #include "internal/status_macros.h" #include "runtime/runtime_options.h" #include "google/protobuf/arena.h" @@ -158,13 +157,6 @@ absl::Status SelectStep::Evaluate(ExecutionFrame* frame) const { result_trail = trail.Step(&field_); } - if (arg->Is()) { - frame->value_stack().PopAndPush( - cel::ErrorValue(cel::runtime_internal::CreateError("Message is NULL")), - std::move(result_trail)); - return absl::OkStatus(); - } - absl::optional optional_arg; if (enable_optional_types_ && arg.IsOptional()) { @@ -354,10 +346,6 @@ class DirectSelectStep : public DirectExpressionStep { case ValueKind::kStruct: case ValueKind::kMap: break; - case ValueKind::kNull: - result = cel::ErrorValue( - cel::runtime_internal::CreateError("Message is NULL")); - return absl::OkStatus(); default: if (optional_arg) { break;