You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Perhaps an orthogonal concern to gh stack but this is a situation that is run into more frequently using it.
Unlike tools like graphite or gerrit which manage reviews as a changeset and track the changes in commits a review refers to, force pushing a branch from commit a to commit b prevents you from reviewing changes from commit a to commit b.
This means having to re-review an entire change set when responding to comments instead of being able to view changes since your last review. Since branches are now force-pushed more frequently this makes it more frustrating to do PR reviews than before.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
Uh oh!
There was an error while loading. Please reload this page.
-
Perhaps an orthogonal concern to
gh stackbut this is a situation that is run into more frequently using it.Unlike tools like graphite or gerrit which manage reviews as a changeset and track the changes in commits a review refers to, force pushing a branch from commit a to commit b prevents you from reviewing changes from commit a to commit b.
This means having to re-review an entire change set when responding to comments instead of being able to view changes since your last review. Since branches are now force-pushed more frequently this makes it more frustrating to do PR reviews than before.
Beta Was this translation helpful? Give feedback.
All reactions