Refactor PromptPexContext by changing RunID and PromptHash fields to values; update related tests for consistency and remove unused test_types.go file

Author: pelikhan

cmd/generate/context.go

@@ -7,7 +7,6 @@ import (
 	"time"
 
 	"github.com/github/gh-models/pkg/prompt"
-	"github.com/github/gh-models/pkg/util"
 )
 
 // createContext creates a new PromptPexContext from a prompt file
@@ -29,11 +28,11 @@ func (h *generateCommandHandler) CreateContextFromPrompt() (*PromptPexContext, e
 	runID := fmt.Sprintf("run_%d", time.Now().Unix())
 	context := &PromptPexContext{
 		// Unique identifier for the run
-		RunID: util.Ptr(runID),
+		RunID: runID,
 		// The prompt content and metadata
 		Prompt: prompt,
 		// Hash of the prompt messages, model, and parameters
-		PromptHash: util.Ptr(promptHash),
+		PromptHash: promptHash,
 		// The options used to generate the prompt
 		Options: h.options,
 	}
@@ -51,8 +50,7 @@ func (h *generateCommandHandler) CreateContextFromPrompt() (*PromptPexContext, e
 		} else {
 			sessionInfo = fmt.Sprintf("reloading session file at %s", *h.sessionFile)
 			// Check if prompt hashes match
-			if existingContext.PromptHash != nil && context.PromptHash != nil &&
-				*existingContext.PromptHash != *context.PromptHash {
+			if existingContext.PromptHash != context.PromptHash {
 				return nil, fmt.Errorf("prompt changed unable to reuse session file")
 			}
 

cmd/generate/generate_test.go

@@ -190,7 +190,7 @@ messages:
 		require.NoError(t, err)
 		require.NotNil(t, ctx)
 		require.NotEmpty(t, ctx.RunID)
-		require.True(t, ctx.RunID != nil)
+		require.True(t, ctx.RunID != "")
 		require.Equal(t, "Test Context Creation", ctx.Prompt.Name)
 		require.Equal(t, "Test description for context", ctx.Prompt.Description)
 		require.Equal(t, options, ctx.Options)

cmd/generate/types.go

@@ -37,15 +37,15 @@ type PromptPexOptions struct {
 
 // PromptPexContext represents the main context for PromptPex operations
 type PromptPexContext struct {
-	RunID        *string           `json:"runId" yaml:"runId"`
+	RunID        string            `json:"runId" yaml:"runId"`
 	Prompt       *prompt.File      `json:"prompt" yaml:"prompt"`
-	PromptHash   *string           `json:"promptHash" yaml:"promptHash"`
+	PromptHash   string            `json:"promptHash" yaml:"promptHash"`
+	Options      *PromptPexOptions `json:"options" yaml:"options"`
 	Intent       *string           `json:"intent" yaml:"intent"`
 	Rules        []string          `json:"rules" yaml:"rules"`
 	InverseRules []string          `json:"inverseRules" yaml:"inverseRules"`
 	InputSpec    *string           `json:"inputSpec" yaml:"inputSpec"`
 	Tests        []PromptPexTest   `json:"tests" yaml:"tests"`
-	Options      *PromptPexOptions `json:"options" yaml:"options"`
 }
 
 // PromptPexTest represents a single test case