Skip to content

Cooldown Incorrectly Applied to github-actions Type #574

@chaseconey

Description

@chaseconey

Describe the bug

When using the cooldown option in the evergreen config, the dependabot.yml that is ultimately pushed will include the cooldown on the github-actions type, which does not support cooldown currently.

To Reproduce

  1. Use normal setup
  2. Use the following evergreen config:
---
cooldown:
  default-days: 7
  semver-major-days: 14
  semver-minor-days: 7
  semver-patch-days: 3
  exclude:
    - "critical-package"

Expected behavior

The cooldown block is only applied to ecosystems that allow that configuration.

Screenshots

Image

Additional context

The produced config given the evergreen config provided looks like so:

version: 2
updates:
  - package-ecosystem: 'npm'
    directory: '/'
    schedule:
      interval: 'weekly'
    groups:
      production-dependencies:
        dependency-type: 'production'
      development-dependencies:
        dependency-type: 'development'
    cooldown:
      default-days: 7
      semver-major-days: 14
      semver-minor-days: 7
      semver-patch-days: 3
      exclude:
        - 'critical-package'
  - package-ecosystem: 'github-actions'
    directory: '/'
    schedule:
      interval: 'weekly'
    groups:
      production-dependencies:
        dependency-type: 'production'
      development-dependencies:
        dependency-type: 'development'
    cooldown:
      default-days: 7
      semver-major-days: 14
      semver-minor-days: 7
      semver-patch-days: 3
      exclude:
        - 'critical-package'

You can see the cooldown key being added to the github-actions ecosystem.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions