Upgrade to C++20 modules - #43
Merged
Merged
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Code reviewFound 4 new issues — see the inline comments. |
gf712
force-pushed
the
modules-upgrade
branch
from
September 4, 2026 09:09
331c2da to
952fde5
Compare
gf712
force-pushed
the
modules-upgrade
branch
from
September 4, 2026 09:09
952fde5 to
edd64a8
Compare
Code reviewFound 1 new issue — see the inline comment. |
Code reviewFound 2 new issues — see the inline comments. |
gf712
force-pushed
the
modules-upgrade
branch
3 times, most recently
from
September 4, 2026 10:16
ece204a to
b8d3341
Compare
The improvements are currently small, but future refactors that remove dependencies that do not support modules should further improve build times. Also a significant boost would be header units to build TUs that depend on mlir targets (currently longest compilation times). However, cmake does not support this.
gf712
force-pushed
the
modules-upgrade
branch
from
September 4, 2026 10:56
b8d3341 to
3312c04
Compare
gf712
force-pushed
the
modules-upgrade
branch
from
September 4, 2026 12:50
a7690c8 to
c7d7d6b
Compare
Code reviewFound 2 new issues — see the inline comments. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.