fix: restore README screenshots and localize image read errors - #62
Merged
EtienneLescot merged 2 commits intoJul 4, 2026
Merged
Conversation
- Restore demo screenshot height to 320px (0.2467 made images invisible) - Align macOS permission instructions with System Settings naming - Reuse settings.imageUpload.errorReading in AnnotationSettingsPanel
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis PR updates README image styling (fixed 320px height) and macOS permissions instructions (System Settings > Privacy & Security), plus localizes a hard-coded error message in AnnotationSettingsPanel.tsx to use an i18n translation key. ChangesREADME Documentation Updates
Annotation Panel Localization
Estimated code review effort: 1 (Trivial) | ~3 minutes 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
EtienneLescot
approved these changes
Jul 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Small fixes for README rendering and a hardcoded UI string.
Changes
README
320pxinstead of0.2467, which made demo images nearly invisible on GitHub)i18n
settings.imageUpload.errorReadingtranslation inAnnotationSettingsPanelinstead of a hardcoded English error message (already used inSettingsPanel)Test plan
Context
Originally prepared against the archived upstream (
siddharthvaddem/openscreen), which no longer accepts PRs. Retargeted to this active continuation fork.Summary by CodeRabbit