You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Feb 14, 2020. It is now read-only.
Right now we don't actually use the CustomElementRegistry, which is standard in the WebComponents draft. Technically none of the Yoru components are currently valid. Use this opportunity to completely rewrite the component instantiation system, it is badly designed and will get hard to maintain (it already is, even for me, who wrote it in the first place)
A better design in the ShadowMaker - Component couple would also fix the broken Preloader. Maybe just get rid of ShadowMaker alltogether, it should now have the responsibility to create shadows in the first place, Components should, as they own the shadowRoot.
Right now we don't actually use the CustomElementRegistry, which is standard in the WebComponents draft. Technically none of the Yoru components are currently valid. Use this opportunity to completely rewrite the component instantiation system, it is badly designed and will get hard to maintain (it already is, even for me, who wrote it in the first place)
A better design in the ShadowMaker - Component couple would also fix the broken Preloader. Maybe just get rid of ShadowMaker alltogether, it should now have the responsibility to create shadows in the first place, Components should, as they own the shadowRoot.