Skip to content

No callbacks for ignored slots? #1

Description

@skipperguy12

Currently you are unable to detect an ignored slot click. This can be helpful when needed to say replace the clicked item with air to allow the player to place his/her item in easily.

This issue can be addressed in 2 ways:

  1. Change https://github.com/gcflames5/menu-framework/blob/master/src%2Fmain%2Fjava%2Fnet%2Fnjay%2FMenuRegistry.java#L98

to not set anything for an ignored slot by default

  1. Add an IgnoredMenuItem annotation and send the callback there rather than modify MenuItem

I'm not sure which would be most developer friendly.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions