fix(helpdesk): 删除 faq_image 孤儿 + notification list 幻影（#380）#409
Merged
Conversation
…380) Delete the unused faq_image duplicate of faq/image, and remove the catalog-missing notification list API (endpoint enum, accessor, re-exports). Breaking: no migration path for the phantom list surface.
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_dc3cc57a-1bf5-49d2-8469-811b17ab2648) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
faq/faq_image孤儿模块（与faq/image生产代码重复，从未 re-export / 挂到Faq）；保留image（含 wiremock e2e）。notification/list幻影 API：list.rs、Notification::list()、公开 re-export、HelpdeskApiV1::NotificationList。Faq::image()。Test plan
cargo test -p openlark-helpdesk --all-features（151 unit + 21 contract）cargo clippy -p openlark-helpdesk --all-targets --all-features -- -Dwarningsfaq_imagemod /NotificationList/ListNotification*残留Closes #380
Note
Medium Risk
Breaking public API removals in helpdesk; impact is limited because removed symbols were orphans or undocumented phantoms, but any external code calling
Notification::list()orfaq_imagewill fail to compile.Overview
Breaking cleanup in
openlark-helpdeskafter catalog/e2e alignment (#351): removes APIs that were never valid or reachable on the public surface.Removes the duplicate
faq/faq_imagemodule (same behavior asfaq/image, never re-exported or exposed onFaq). FAQ images stay onFaq::image()andHelpdeskApiV1::FaqImage(wiremock e2e unchanged).Removes the phantom
notification/listsurface (GET /open-apis/helpdesk/v1/notifications):list.rs,Notification::list(),ListNotification*re-exports, andHelpdeskApiV1::NotificationList. The eight catalog-backed notification endpoints remain.CHANGELOG records no migration for list (no Feishu catalog/docs); callers on list must drop that usage. FAQ image callers should use
Faq::image()only.Reviewed by Cursor Bugbot for commit 66f3170. Bugbot is set up for automated code reviews on this repo. Configure here.