From 5785768516ffc6f046b0f0e5a971ef060dfcc442 Mon Sep 17 00:00:00 2001 From: "flamingo[bot]" <277372822+flamingo[bot]@users.noreply.github.com> Date: Fri, 14 Aug 2026 14:23:47 +0000 Subject: [PATCH 1/2] fix(MAJORLEA-007): 3 review findings across 2 files --- kubernetes/base/cache-updater-service.yaml | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/kubernetes/base/cache-updater-service.yaml b/kubernetes/base/cache-updater-service.yaml index 84a7940..b28b3f0 100644 --- a/kubernetes/base/cache-updater-service.yaml +++ b/kubernetes/base/cache-updater-service.yaml @@ -42,7 +42,7 @@ spec: - name: SPRING_REDIS_HOST value: "${REDIS_HOST}" - name: SPRING_REDIS_PORT - value: "6379" + value: "${REDIS_PORT}" - name: JAVA_MIN_HEAP value: "${JAVA_MIN_HEAP}" - name: JAVA_MAX_HEAP @@ -69,7 +69,15 @@ spec: initialDelaySeconds: 90 periodSeconds: 30 timeoutSeconds: 5 - failureThreshold: 3 + failureThreshold: 3 + readinessProbe: + httpGet: + path: /actuator/health/readiness + port: ${SERVER_PORT} + initialDelaySeconds: 30 + periodSeconds: 10 + timeoutSeconds: 5 + failureThreshold: 3 --- apiVersion: v1 kind: Service @@ -86,4 +94,4 @@ spec: - name: http port: ${SERVER_PORT} targetPort: ${SERVER_PORT} - type: ClusterIP \ No newline at end of file + type: ClusterIP From 8ba36e93c5437604e9d39be8fe1bf07a43148434 Mon Sep 17 00:00:00 2001 From: "flamingo[bot]" <277372822+flamingo[bot]@users.noreply.github.com> Date: Fri, 14 Aug 2026 14:23:48 +0000 Subject: [PATCH 2/2] fix(MAJORLEA-007): 3 review findings across 2 files --- kubernetes/base/config.yaml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/kubernetes/base/config.yaml b/kubernetes/base/config.yaml index 0395d06..0c3581a 100644 --- a/kubernetes/base/config.yaml +++ b/kubernetes/base/config.yaml @@ -9,7 +9,7 @@ data: JAVA_OPTS: "-Xmx${JAVA_MAX_HEAP} -Xms${JAVA_MIN_HEAP} -XX:+HeapDumpOnOutOfMemoryError -XX:HeapDumpPath=/tmp" CACHE_IMPLEMENTATION: "redis" SPRING_DATA_REDIS_HOST: "${REDIS_HOST}" - SPRING_DATA_REDIS_PORT: "6379" + SPRING_DATA_REDIS_PORT: "${REDIS_PORT}" --- apiVersion: v1 kind: ConfigMap @@ -42,5 +42,5 @@ kind: ConfigMap metadata: name: frontend-config data: - NODE_ENV: "${NODE_ENV:-production}" - API_TIMEOUT: "${API_TIMEOUT:-30000}" \ No newline at end of file + NODE_ENV: "${NODE_ENV}" + API_TIMEOUT: "${API_TIMEOUT}"