From 0262acb89e9cab090d9ee1d0c1de8dd09e4b7786 Mon Sep 17 00:00:00 2001 From: "flamingo[bot]" <277372822+flamingo[bot]@users.noreply.github.com> Date: Fri, 14 Aug 2026 14:23:33 +0000 Subject: [PATCH 1/7] fix(MAJORLEA-002-2): 8 review findings across 7 files --- .../flamingo/analysis/model/Contributor.java | 27 ++++++++++++------- 1 file changed, 17 insertions(+), 10 deletions(-) diff --git a/backend/src/main/java/cx/flamingo/analysis/model/Contributor.java b/backend/src/main/java/cx/flamingo/analysis/model/Contributor.java index e667943..d737c12 100644 --- a/backend/src/main/java/cx/flamingo/analysis/model/Contributor.java +++ b/backend/src/main/java/cx/flamingo/analysis/model/Contributor.java @@ -5,11 +5,15 @@ import java.util.List; import java.util.Map; +import lombok.AllArgsConstructor; import lombok.Builder; import lombok.Data; +import lombok.NoArgsConstructor; @Data @Builder(toBuilder = true) +@NoArgsConstructor +@AllArgsConstructor public class Contributor { public enum Role { CONTRIBUTOR, @@ -46,16 +50,19 @@ public enum Role { public Map getGithubStats() { if (type == Role.CONTRIBUTOR) { - // For contributors, convert individual fields to map format - Map stats = new HashMap<>(); - stats.put("score", score); - stats.put("totalCommits", totalCommits); - stats.put("javaRepos", javaRepos); - stats.put("starsReceived", starsReceived); - stats.put("forksReceived", forksReceived); - stats.put("starsGiven", starsGiven); - stats.put("forksGiven", forksGiven); - return stats; + // For contributors, convert individual fields to map format and cache in field + if (githubStats == null) { + Map stats = new HashMap<>(); + stats.put("score", score); + stats.put("totalCommits", totalCommits); + stats.put("javaRepos", javaRepos); + stats.put("starsReceived", starsReceived); + stats.put("forksReceived", forksReceived); + stats.put("starsGiven", starsGiven); + stats.put("forksGiven", forksGiven); + githubStats = stats; + } + return githubStats; } return githubStats; } From 5d937b1b501002a31c56e761ee03e74d4c0d45dc Mon Sep 17 00:00:00 2001 From: "flamingo[bot]" <277372822+flamingo[bot]@users.noreply.github.com> Date: Fri, 14 Aug 2026 14:23:34 +0000 Subject: [PATCH 2/7] fix(MAJORLEA-002-2): 8 review findings across 7 files --- .../main/java/cx/flamingo/analysis/model/JobOpening.java | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/backend/src/main/java/cx/flamingo/analysis/model/JobOpening.java b/backend/src/main/java/cx/flamingo/analysis/model/JobOpening.java index 62e29e6..3e31d35 100644 --- a/backend/src/main/java/cx/flamingo/analysis/model/JobOpening.java +++ b/backend/src/main/java/cx/flamingo/analysis/model/JobOpening.java @@ -1,13 +1,17 @@ package cx.flamingo.analysis.model; +import lombok.AllArgsConstructor; import lombok.Builder; import lombok.Data; +import lombok.NoArgsConstructor; @Data @Builder +@NoArgsConstructor +@AllArgsConstructor public class JobOpening { private String id; private String title; private String location; private String url; -} \ No newline at end of file +} From 89ba720db377a0a1b5c379423cc059b8ecfb5d91 Mon Sep 17 00:00:00 2001 From: "flamingo[bot]" <277372822+flamingo[bot]@users.noreply.github.com> Date: Fri, 14 Aug 2026 14:23:35 +0000 Subject: [PATCH 3/7] fix(MAJORLEA-002-2): 8 review findings across 7 files --- backend/src/main/java/cx/flamingo/analysis/model/City.java | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/backend/src/main/java/cx/flamingo/analysis/model/City.java b/backend/src/main/java/cx/flamingo/analysis/model/City.java index 492053c..edbe932 100644 --- a/backend/src/main/java/cx/flamingo/analysis/model/City.java +++ b/backend/src/main/java/cx/flamingo/analysis/model/City.java @@ -4,11 +4,15 @@ import com.fasterxml.jackson.annotation.JsonInclude; +import lombok.AllArgsConstructor; import lombok.Builder; import lombok.Data; +import lombok.NoArgsConstructor; @Data @Builder +@NoArgsConstructor +@AllArgsConstructor @JsonInclude(JsonInclude.Include.NON_NULL) public class City { private String id; @@ -24,4 +28,4 @@ public class City { private State state; private Set regions; private SoccerTeam nearestTeam; -} \ No newline at end of file +} From 7f69ac21bd48fba3314ac837a36acc09db045f2b Mon Sep 17 00:00:00 2001 From: "flamingo[bot]" <277372822+flamingo[bot]@users.noreply.github.com> Date: Fri, 14 Aug 2026 14:23:36 +0000 Subject: [PATCH 4/7] fix(MAJORLEA-002-2): 8 review findings across 7 files --- .../src/main/java/cx/flamingo/analysis/model/Language.java | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/backend/src/main/java/cx/flamingo/analysis/model/Language.java b/backend/src/main/java/cx/flamingo/analysis/model/Language.java index b9e12e0..951a0bc 100644 --- a/backend/src/main/java/cx/flamingo/analysis/model/Language.java +++ b/backend/src/main/java/cx/flamingo/analysis/model/Language.java @@ -2,15 +2,19 @@ import com.fasterxml.jackson.annotation.JsonInclude; +import lombok.AllArgsConstructor; import lombok.Builder; import lombok.Data; +import lombok.NoArgsConstructor; @Data @Builder +@NoArgsConstructor +@AllArgsConstructor @JsonInclude(JsonInclude.Include.NON_NULL) public class Language { private String id; private String name; private String displayName; private String iconUrl; -} \ No newline at end of file +} From 7779638470ea0c1b57aede2e7918ebd1788e105e Mon Sep 17 00:00:00 2001 From: "flamingo[bot]" <277372822+flamingo[bot]@users.noreply.github.com> Date: Fri, 14 Aug 2026 14:23:37 +0000 Subject: [PATCH 5/7] fix(MAJORLEA-002-2): 8 review findings across 7 files --- backend/src/main/java/cx/flamingo/analysis/model/State.java | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/backend/src/main/java/cx/flamingo/analysis/model/State.java b/backend/src/main/java/cx/flamingo/analysis/model/State.java index 21949a3..6910aee 100644 --- a/backend/src/main/java/cx/flamingo/analysis/model/State.java +++ b/backend/src/main/java/cx/flamingo/analysis/model/State.java @@ -4,11 +4,15 @@ import com.fasterxml.jackson.annotation.JsonInclude; +import lombok.AllArgsConstructor; import lombok.Builder; import lombok.Data; +import lombok.NoArgsConstructor; @Data @Builder +@NoArgsConstructor +@AllArgsConstructor @JsonInclude(JsonInclude.Include.NON_NULL) public class State { private String id; From 4b47950f8a897a1a33bddf050978776c2163fa64 Mon Sep 17 00:00:00 2001 From: "flamingo[bot]" <277372822+flamingo[bot]@users.noreply.github.com> Date: Fri, 14 Aug 2026 14:23:38 +0000 Subject: [PATCH 6/7] fix(MAJORLEA-002-2): 8 review findings across 7 files --- .../main/java/cx/flamingo/analysis/model/ApiResponse.java | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/backend/src/main/java/cx/flamingo/analysis/model/ApiResponse.java b/backend/src/main/java/cx/flamingo/analysis/model/ApiResponse.java index 7ad2417..968e3db 100644 --- a/backend/src/main/java/cx/flamingo/analysis/model/ApiResponse.java +++ b/backend/src/main/java/cx/flamingo/analysis/model/ApiResponse.java @@ -1,10 +1,14 @@ package cx.flamingo.analysis.model; +import lombok.AllArgsConstructor; import lombok.Builder; import lombok.Data; +import lombok.NoArgsConstructor; @Data @Builder +@NoArgsConstructor +@AllArgsConstructor public class ApiResponse { private String status; private String message; @@ -31,4 +35,4 @@ public static ApiResponse error(String message) { .message(message) .build(); } -} \ No newline at end of file +} From 5b903bba470e20340b8b068969d2fbd4c51f2b73 Mon Sep 17 00:00:00 2001 From: "flamingo[bot]" <277372822+flamingo[bot]@users.noreply.github.com> Date: Fri, 14 Aug 2026 14:23:40 +0000 Subject: [PATCH 7/7] fix(MAJORLEA-002-2): 8 review findings across 7 files --- .../java/cx/flamingo/analysis/model/Region.java | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/backend/src/main/java/cx/flamingo/analysis/model/Region.java b/backend/src/main/java/cx/flamingo/analysis/model/Region.java index 06c2633..bd594e7 100644 --- a/backend/src/main/java/cx/flamingo/analysis/model/Region.java +++ b/backend/src/main/java/cx/flamingo/analysis/model/Region.java @@ -2,9 +2,15 @@ import java.util.Set; -import lombok.Value; +import lombok.AllArgsConstructor; +import lombok.Builder; +import lombok.Data; +import lombok.NoArgsConstructor; -@Value +@Data +@Builder +@NoArgsConstructor +@AllArgsConstructor public class Region { String id; String name; // Internal name (e.g., "new-england") @@ -16,7 +22,10 @@ public class Region { Set states; Set cities; - @Value + @Data + @Builder + @NoArgsConstructor + @AllArgsConstructor public static class GeoCoordinates { double latitude; double longitude;