Skip to content

onload && onload.apply 类似的检验不严谨导致使用不便的问题 #46

Description

@menglexing

示例:

function getXXX (callback) {
    require.async('xxx', callback)
}

// 预加载
// 这样的使用方式,会导致传递给 require.async 的callback 会是 jq的event对象
// 因为modJS内部的判断 onload && onload.apply... 不够严谨进而导致报错
$(window).on('load', getXXX)    

// 主动加载
$('#showXXX').on('click', function(e){
    getXXX(function(xxx){
        xxx.show()
    })
})

我不得已给getXXX加上了参数校验:

function getXXX (callback) {
    if (typeof callback !== 'function') callback = function () {};

    require.async('xxx', callback)
}

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions