Skip to content

Fixes and Timestamp#44

Merged
sirewix merged 4 commits into
mainfrom
sirewix/fixes-and-timestamp
Apr 16, 2026
Merged

Fixes and Timestamp#44
sirewix merged 4 commits into
mainfrom
sirewix/fixes-and-timestamp

Conversation

@sirewix

@sirewix sirewix commented Apr 14, 2026

Copy link
Copy Markdown
Contributor

@sirewix
sirewix requested a review from a team as a code owner April 14, 2026 08:49
@CLAassistant

CLAassistant commented Apr 14, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@codecov

codecov Bot commented Apr 14, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 16.66667% with 40 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.42%. Comparing base (9c875aa) to head (1086625).
⚠️ Report is 4 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/timestamp.rs 0.00% 31 Missing ⚠️
src/base_url.rs 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #44      +/-   ##
==========================================
- Coverage   67.89%   61.42%   -6.47%     
==========================================
  Files           6        7       +1     
  Lines         380      420      +40     
==========================================
  Hits          258      258              
- Misses        122      162      +40     
Files with missing lines Coverage Δ
src/config.rs 61.90% <ø> (ø)
src/duration.rs 84.69% <100.00%> (ø)
src/lib.rs 64.55% <ø> (ø)
src/base_url.rs 60.60% <0.00%> (-9.57%) ⬇️
src/timestamp.rs 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c875aa...1086625. Read the comment docs.

@RasmusRendal RasmusRendal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can add "this closes #43" to the PR description! :D

Comment thread src/timestamp.rs Outdated
@sirewix
sirewix force-pushed the sirewix/fixes-and-timestamp branch from ff8ac12 to 1086625 Compare April 14, 2026 11:18
@sirewix
sirewix merged commit 1086625 into main Apr 16, 2026
5 of 7 checks passed
@sirewix
sirewix deleted the sirewix/fixes-and-timestamp branch April 16, 2026 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fails to compile with -F schemars -F serde

5 participants