Problem
New changes that come from Meta sync ups sometimes cause the PR validation issues.
As a result, submitting 3rd party PRs often cause unexpected issues, because the code in static_h does not pass them.
It may also cause the static_h code to be in an unstable state.
Solution
The internal Meta sync up commits must not merge unless they pass all PR validation tests.
Additional Context
For example, the build break here: https://github.com/facebook/hermes/actions/runs/22562594893/job/65352130925?pr=1922
C:\a\hermes\hermes\hermes\lib\Support\FastArraySearch.cpp(106,43): error C2078: too many initializers [C:\a\hermes\hermes\build\lib\Support\hermesSupport_obj.vcxproj]
C:\a\hermes\hermes\hermes\lib\Support\FastArraySearch.cpp(106,43):
the template instantiation context (the oldest one first) is
C:\a\hermes\hermes\hermes\lib\Support\FastArraySearch.cpp(232,10):
see reference to function template instantiation 'int64_t hermes::`anonymous-namespace'::searchU32Impl<false>(llvh::ArrayRef<uint32_t>,size_t,size_t,uint32_t)' being compiled
C:\a\hermes\hermes\hermes\lib\Support\FastArraySearch.cpp(106,43): error C2131: expression did not evaluate to a constant [C:\a\hermes\hermes\build\lib\Support\hermesSupport_obj.vcxproj]
C:\a\hermes\hermes\hermes\lib\Support\FastArraySearch.cpp(106,43):
a non-constant (sub-)expression was encountered
It is caused by the commit: f2827aa
This commit fails 2 tests.
It seems that the PR validation is run, but it is run after the commit and it does not stop the commit if something is wrong.
Problem
New changes that come from Meta sync ups sometimes cause the PR validation issues.
As a result, submitting 3rd party PRs often cause unexpected issues, because the code in
static_hdoes not pass them.It may also cause the
static_hcode to be in an unstable state.Solution
The internal Meta sync up commits must not merge unless they pass all PR validation tests.
Additional Context
For example, the build break here: https://github.com/facebook/hermes/actions/runs/22562594893/job/65352130925?pr=1922
It is caused by the commit: f2827aa
This commit fails 2 tests.
It seems that the PR validation is run, but it is run after the commit and it does not stop the commit if something is wrong.