~1MB increase in size

[tux2nicolae]

We just upgraded from react-native 0.84.0 to 0.84.1 and noticed a huge increase in size on IOS due to hermesvm framework from

5.961.216 bytes (6 MB on disk) to
6.945.392 bytes (6,9 MB on disk)

Did something major happend to justify this huge increase in binary size?

This is an issue for use since we are trying to use it in an appclip on ios which has a hard limit of full app to 15MB.

[cipolleschi]

I assume you are using Hermes V1, the changes we made are here: hermes-v250829098.0.8...hermes-v250829098.0.9

I'm not sure whether some of these changes might have impacted the size of Hermes.

[cipolleschi]

@tux2nicolae from where did you get that number? From the app running or just checking the disk space?

[tux2nicolae]

@cipolleschi Yes we use v1 in one of our apps, we noticed the bundle size increase and I've checked by clicking on "show package contents" then noticed the difference between hermesvm.framework files on disk

Hope I won't steer you down the wrong track, I will test it later today again to confirm it, maybe I'm just missing something and It's just my fault in measuring it, or it has something to do with my setup.

[bencripps]

I believe we're running into the same issue, upgrading from 0.81.4 to 0.83, which is in range. Our size increase was also ~1mb.

[ivankra]

Hermes V1 is about 1MB larger than the old. Comparing size of stripped cli binaries from main branch vs static_h (Hermes V1):

-r-xr-xr-x 1 root root 3612552 Apr  8 07:29 hermes_clang
-r-xr-xr-x 1 root root 4660016 Apr  8 07:01 hermes-v1_clang

[lavenzg]

Comparing the CLI binary is not very meaningful. It includes more changes that won't be built into the hermesvm library.

I noticed that the OSS CMake build is not specifying the HERMES_IS_MOBILE_BUILD flag on iOS (while it does so on Android). I have ported a fix to the stable branch (fb8da5b).

I tested locally with this flag set, the size difference is about ~400KB on the hermesvm library (both stripped):

# legacy hermes
1.6M Apr 14 12:57 cmake-build-minsizerel/lib/libhermesvm.dylib
# hermes v1
2.0M Apr 14 12:59 cmake-build-minsizerel/lib/libhermesvm.dylib