Remove unistd.h dependency

[JPTIZ]

unistd.h stands for "Unix Standard API". For Windows Native build, no Unix/POSIX should be used.

Suggestions

See where it is included and what does it include.

[JPTIZ]

According to unistd.h manual, these are the declarations defined in it:

int          access(const char *, int);
unsigned int alarm(unsigned int);
int          brk(void *);
int          chdir(const char *);
int          chroot(const char *); (LEGACY)
int          chown(const char *, uid_t, gid_t);
int          close(int);
size_t       confstr(int, char *, size_t);
char        *crypt(const char *, const char *);
char        *ctermid(char *);
char        *cuserid(char *s); (LEGACY)
int          dup(int);
int          dup2(int, int);
void         encrypt(char[64], int);
int          execl(const char *, const char *, ...);
int          execle(const char *, const char *, ...);
int          execlp(const char *, const char *, ...);
int          execv(const char *, char *const []);
int          execve(const char *, char *const [], char *const []);
int          execvp(const char *, char *const []);
void        _exit(int);
int          fchown(int, uid_t, gid_t);
int          fchdir(int);
int          fdatasync(int);
pid_t        fork(void);
long int     fpathconf(int, int);
int          fsync(int);
int          ftruncate(int, off_t);
char        *getcwd(char *, size_t);
int          getdtablesize(void); (LEGACY)
gid_t        getegid(void);
uid_t        geteuid(void);
gid_t        getgid(void);
int          getgroups(int, gid_t []);
long         gethostid(void);
char        *getlogin(void);
int          getlogin_r(char *, size_t);
int          getopt(int, char * const [], const char *);
int          getpagesize(void); (LEGACY)
char        *getpass(const char *); (LEGACY)
pid_t        getpgid(pid_t);
pid_t        getpgrp(void);
pid_t        getpid(void);
pid_t        getppid(void);
pid_t        getsid(pid_t);
uid_t        getuid(void);
char        *getwd(char *);
int          isatty(int);
int          lchown(const char *, uid_t, gid_t);
int          link(const char *, const char *);
int          lockf(int, int, off_t);
off_t        lseek(int, off_t, int);
int          nice(int);
long int     pathconf(const char *, int);
int          pause(void);
int          pipe(int [2]);
ssize_t      pread(int, void *, size_t, off_t);
int          pthread_atfork(void (*)(void), void (*)(void),
                 void(*)(void));
ssize_t      pwrite(int, const void *, size_t, off_t);
ssize_t      read(int, void *, size_t);
int          readlink(const char *, char *, size_t);
int          rmdir(const char *);
void        *sbrk(intptr_t);
int          setgid(gid_t);
int          setpgid(pid_t, pid_t);
pid_t        setpgrp(void);
int          setregid(gid_t, gid_t);
int          setreuid(uid_t, uid_t);
pid_t        setsid(void);
int          setuid(uid_t);
unsigned int sleep(unsigned int);
void         swab(const void *, void *, ssize_t);
int          symlink(const char *, const char *);
void         sync(void);
long int     sysconf(int);
pid_t        tcgetpgrp(int);
int          tcsetpgrp(int, pid_t);
int          truncate(const char *, off_t);
char        *ttyname(int);
int          ttyname_r(int, char *, size_t);
useconds_t   ualarm(useconds_t, useconds_t);
int          unlink(const char *);
int          usleep(useconds_t);
pid_t        vfork(void);
ssize_t      write(int, const void *, size_t);

[caiosignor]

I have worked with unistd.h. No function has been implemented, actually, it just exports the variables used by getopt.

https://github.com/expertisesolutions/efl/tree/devs/carlos/unistd

[JPTIZ]

I have worked with unistd.h. No function has been implemented, actually, it just exports the variables used by getopt.

https://github.com/expertisesolutions/efl/tree/devs/carlos/unistd

You can make a Draft PR for that then, so we both (or just me if you're doing another thing) can work on this :)

[caiosignor]

here are the functions declared in unistd and that are not in win32 api. They are used by EFL.

alarm is in glibc/posix/alarm.c
chown
fchown
fork is in glibc/posix/fork.c
fpathconf is in glibc/posix/fpathconf.c
ftruncate
geteuid is in glibc/posix/geteuid.c
getgid is in glibc/posix/getgid.c
getpagesize
getuid is in glibc/posix/getuid.c
pathconf is in glibc/posix/pathconf.c
pause is in glibc/posix/pause.c
pipe
readlink
setreuid
setsid is in glibc/posix/setsid.c
setuid is in glibc/posix/setuid.c
sleep is in glibc/posix/sleep.c
symlink
sysconf is in glibc/posix/sysconf.c
usleep
vfork is in glibc/posix/vfork.c

[caiosignor]

I've updated the list above with the context where theses functions are used
the current branch is: /devs/carlos/unistd

• alarm
  there is a alternative impl using win32 api in src\generic\evas\common\timeout.c
• chown
  my impl eina_chown is at src\lib\eina\eina_util.c
• fchown
  #ifndef _WIN32 in src\lib\efreet\efreet.c
• fork
  used in src\examples\ecore\ecore_pipe_simple_example.c
  #ifdef HAVE_FORK in multiples files
• ftruncate
  used in multiples files
• getgid
  #ifndef _WIN32 in src\lib\efreet\efreet.c
• getpagesize
  #if defined HAVE_GETPAGESIZE in src\lib\eina\eina_cpu.c
  used in src\modules\evas\engines\fb\evas_fb_main.c
• getuid
  #if defined(HAVE_GETUID) && defined(HAVE_GETEUID) in multiples files
• fpathconf
  #if defined(HAVE_FPATHCONF) in src\lib\eina\eina_file.c
• pathconf
  #if defined(HAVE_FPATHCONF) && defined(HAVE_DIRFD) && defined(_PC_NAME_MAX) in src\lib\eina\eina_file.c
• pause
  #ifdef HAVE_PAUSE pause() #else eina_sleep() in src\lib\ecore\ecore_main.c
• pipe
  sounds like there is a impl in src\lib\ecore\ecore_pipe.c for win32 and there is a #define pipe to evil_pipe() in src\lib\evil\evil_macro_wrapper.h
• readlink
  #if !defined(_WIN32) in src\tests\eina\eina_test_file.c, src\lib\eio\eio_dir.c, src\lib\ecore_file\ecore_file.c
  used in src\bin\elementary\run.c
• setreuid
  #if defined(HAVE_GETUID) && defined(HAVE_GETEUID) src\lib\eina\eina_vpath.c
  *setsid
  #ifdef HAVE_FORK in src\lib\elementary\elm_main.c
  used in src\lib\ecore\efl_exe.c and src\lib\ecore\ecore_exe_posix.c
• sleep and usleep
  are used in multiples files
• my impl about sleep is at src\lib\eina\eina_util.c
• symlink
  #ifndef _WIN32 in src\lib\ecore_file\ecore_file.c and src\lib\eio\eio_dir.c
• sysconf
  there is alternative impl in src\lib\eina\eina_cpu.c

[vtorri]

everything that are related to symlink should already be disabled on Windows. It's not possible to manage symlink if you are not administrator. And even with the rights, they are not equivalent to unix symlink.

chown is useless on Windows. The purpose of the usage of chown is for someone to change (for example) group of another account. It is not possible as a simple user (maybe as administrator). And what is the interest of changing its own group ?

pipe() is the one ine evil, but honestly, WIN32 anonymous pipes should be used instead (mainly in ecore_anim and ecore_pipe). Anonymous pipes seem also a bit faster

framebuffer (evas_fb_main.c) is a linux thing, not windows, thus can be ignored

maybe eina_sleep should be inlined

about that list, you should actually split it :

• one of useless usage of such function (not applicable on Windows, like fork, etc...)
• one which shuold be used on Windows too

and note that evil is specifically for Windows, so having code like #ifdef _WIN32 #else is useless

Also note that i'm planning to remove more and more functions in evil and move it somewhere else (certainly in eina for most of them). Ultimately, i want to remove evil.

[JPTIZ]

everything that are related to symlink should already be disabled on Windows. It's not possible to manage symlink if you are not administrator. And even with the rights, they are not equivalent to unix symlink.

chown is useless on Windows. The purpose of the usage of chown is for someone to change (for example) group of another account. It is not possible as a simple user (maybe as administrator). And what is the interest of changing its own group ?

pipe() is the one ine evil, but honestly, WIN32 anonymous pipes should be used instead (mainly in ecore_anim and ecore_pipe). Anonymous pipes seem also a bit faster

framebuffer (evas_fb_main.c) is a linux thing, not windows, thus can be ignored

maybe eina_sleep should be inlined

about that list, you should actually split it :

* one of useless usage of such function (not applicable on Windows, like fork, etc...)

* one which shuold be used on Windows too

and note that evil is specifically for Windows, so having code like #ifdef _WIN32 #else is useless

Also note that i'm planning to remove more and more functions in evil and move it somewhere else (certainly in eina for most of them). Ultimately, i want to remove evil.

Thanks for the tips! Although the code changed a lot since Carlos (@caiosignor)'s messsage, that might help when submiting our current changes to upstream. Gonna check them a little closer when making the diffs.