Checklist
In order to improve the time, how long a bugfix does take, please make sure you address as much as possible of the following checklist.
Tip: Adding screenshots, outputs and logs might help to improve clarity.
Summary
In #768, we added a check after checks.yml to call report.yml. We need a slight modification as a CI step is red but can still pass all checks for the PR to be merged.
The issue is that we still upload a metric.json file at the end of the report.yml:
https://github.com/exasol/python-toolbox/blob/main/.github/workflows/report.yml#L52
See this failed CI step:
https://github.com/exasol/python-toolbox/actions/runs/24336562015/job/71061423228
To fix this, we need to either:
Calls to report.yml from other GitHub workflows of the PTB:
ci.yml
- on regular schedule (Y) (1)
- on pull_request (Y)
merge-gate.yml
- via calling
checks.yml (-)
- directly later on (-)
Remarks:
- (Y) file
metrics.json should be uploaded
- (-) file
metrics.json should not be uploaded
- (1)
- since scheduled runs lack interaction,
- slow tests will not be approved manually,
- hence report.yml will never be executed
- File
metrics.json will never be uploaded, anyway
Tasks
Checklist
In order to improve the time, how long a bugfix does take, please make sure you address as much as possible of the following checklist.
Tip: Adding screenshots, outputs and logs might help to improve clarity.
Summary
In #768, we added a check after
checks.ymlto callreport.yml. We need a slight modification as a CI step is red but can still pass all checks for the PR to be merged.The issue is that we still upload a
metric.jsonfile at the end of thereport.yml:https://github.com/exasol/python-toolbox/blob/main/.github/workflows/report.yml#L52
See this failed CI step:
https://github.com/exasol/python-toolbox/actions/runs/24336562015/job/71061423228
To fix this, we need to either:
report.yml- where we could putfastorslowCalls to
report.ymlfrom other GitHub workflows of the PTB:ci.ymlmerge-gate.ymlchecks.yml(-)Remarks:
metrics.jsonshould be uploadedmetrics.jsonshould not be uploadedmetrics.jsonwill never be uploaded, anywayTasks
exasol/toolbox/templates/github/workflows/