TopDisc spec clarification

[SionoiS]

Hello!

I would like the understand better the relationship between the admission control mechanism, the advertiser and the ENR.

Which IP is used to calculate waiting time? The advertiser or the ENR's IP? Are they always the same?

Is it mandatory for the advertiser to always use it's own ENR? What about using ENR of third parties?

For context, we are working on our own DISC-NG derived spec but on the libp2p stack.

Thanks!

[harnen]

Hi @SionoiS,

Thanks for flagging that up. The code currently uses the ENR's IP, but it might not be the correct behaviour. As you mention, one might use someone's or a dummy ENR record. One solution would be to check whether the network address equals the one from the ENR. However, I'm not yet sure this doesn't introduce some additional problems (e.g., NAT?). Let us discuss and we'll get back to you + update the spec if needed.