evictOldBuilders (execution/execmodule/block_building.go) removes old BlockBuilders from the map without calling Stop(). Their build goroutines keep running until the max-build-time self-stop even though the result can no longer be fetched — wasted CPU/IO per orphaned build, and the orphan keeps reading through its by-then stale snapshot for longer than necessary.
Stop evicted builders on eviction. (The shared-cache poisoning risk such orphans used to pose is gone since #22198 detached builds from the BranchCache; the remaining cost is wasted work.)
evictOldBuilders(execution/execmodule/block_building.go) removes oldBlockBuilders from the map without callingStop(). Their build goroutines keep running until the max-build-time self-stop even though the result can no longer be fetched — wasted CPU/IO per orphaned build, and the orphan keeps reading through its by-then stale snapshot for longer than necessary.Stop evicted builders on eviction. (The shared-cache poisoning risk such orphans used to pose is gone since #22198 detached builds from the BranchCache; the remaining cost is wasted work.)