From 2f84592b7d31c9d930534953c2dead5f08dc8d23 Mon Sep 17 00:00:00 2001 From: EddyCMWF Date: Wed, 17 Jun 2026 11:43:44 +0100 Subject: [PATCH 1/6] RETRIABLE in available in previous location --- multiurl/http.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/multiurl/http.py b/multiurl/http.py index d7ffabe..0ba5153 100644 --- a/multiurl/http.py +++ b/multiurl/http.py @@ -21,11 +21,10 @@ from .base import DownloaderBase from .multipart import DecodeMultipart, PartFilter, compute_byte_ranges -from .retry import robust +from .retry import robust, RETRIABLE LOG = logging.getLogger(__name__) - @dataclass class ServerCapabilities: accept_ranges: bool From 2682ece24df3b75e7cd711c804411019e4446245 Mon Sep 17 00:00:00 2001 From: EddyCMWF Date: Wed, 17 Jun 2026 11:50:30 +0100 Subject: [PATCH 2/6] update tests --- tests/test_http.py | 7 +++++++ tests/test_robust.py | 5 +++++ 2 files changed, 12 insertions(+) create mode 100644 tests/test_http.py diff --git a/tests/test_http.py b/tests/test_http.py new file mode 100644 index 0000000..a1b2bd8 --- /dev/null +++ b/tests/test_http.py @@ -0,0 +1,7 @@ +from multiurl.http import RETRIABLE + + +def test_retriable_is_list_of_strings(): + assert isinstance(RETRIABLE, list) + assert all(isinstance(item, str) for item in RETRIABLE) + diff --git a/tests/test_robust.py b/tests/test_robust.py index 6df3fd0..cb53f81 100644 --- a/tests/test_robust.py +++ b/tests/test_robust.py @@ -37,6 +37,11 @@ def killer(): save.cancel() +def test_retriable_is_list_of_strings(): + assert isinstance(RETRIABLE, list) + assert all(isinstance(item, str) for item in RETRIABLE) + + def test_robust(): sleep = 5 with timeout(len(RETRIABLE * sleep * 10)): From c72487003ed7398378afb26829e91e7224f95ab4 Mon Sep 17 00:00:00 2001 From: EddyCMWF Date: Wed, 17 Jun 2026 11:58:40 +0100 Subject: [PATCH 3/6] only check it's a list or tuple --- tests/test_http.py | 1 - tests/test_robust.py | 1 - 2 files changed, 2 deletions(-) diff --git a/tests/test_http.py b/tests/test_http.py index a1b2bd8..d4a5ab5 100644 --- a/tests/test_http.py +++ b/tests/test_http.py @@ -3,5 +3,4 @@ def test_retriable_is_list_of_strings(): assert isinstance(RETRIABLE, list) - assert all(isinstance(item, str) for item in RETRIABLE) diff --git a/tests/test_robust.py b/tests/test_robust.py index cb53f81..334a3e2 100644 --- a/tests/test_robust.py +++ b/tests/test_robust.py @@ -39,7 +39,6 @@ def killer(): def test_retriable_is_list_of_strings(): assert isinstance(RETRIABLE, list) - assert all(isinstance(item, str) for item in RETRIABLE) def test_robust(): From ba0c60acf8bbb483d42e7c3bbeb59803a6120d21 Mon Sep 17 00:00:00 2001 From: EddyCMWF Date: Wed, 17 Jun 2026 11:58:47 +0100 Subject: [PATCH 4/6] only check it's a list or tuple --- tests/test_http.py | 2 +- tests/test_robust.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/test_http.py b/tests/test_http.py index d4a5ab5..917dbeb 100644 --- a/tests/test_http.py +++ b/tests/test_http.py @@ -2,5 +2,5 @@ def test_retriable_is_list_of_strings(): - assert isinstance(RETRIABLE, list) + assert isinstance(RETRIABLE, (list, tuple)) diff --git a/tests/test_robust.py b/tests/test_robust.py index 334a3e2..fab4dc7 100644 --- a/tests/test_robust.py +++ b/tests/test_robust.py @@ -38,7 +38,7 @@ def killer(): def test_retriable_is_list_of_strings(): - assert isinstance(RETRIABLE, list) + assert isinstance(RETRIABLE, (list, tuple)) def test_robust(): From 641d553f13c3b805c12a34c77a4d0f3bc6302ae9 Mon Sep 17 00:00:00 2001 From: EddyCMWF Date: Wed, 17 Jun 2026 11:59:53 +0100 Subject: [PATCH 5/6] revert line deletion --- multiurl/http.py | 1 + 1 file changed, 1 insertion(+) diff --git a/multiurl/http.py b/multiurl/http.py index 0ba5153..b9c760d 100644 --- a/multiurl/http.py +++ b/multiurl/http.py @@ -25,6 +25,7 @@ LOG = logging.getLogger(__name__) + @dataclass class ServerCapabilities: accept_ranges: bool From 8a22c551b484027e138ee7c4ca38335d8da47144 Mon Sep 17 00:00:00 2001 From: EddyCMWF Date: Wed, 17 Jun 2026 12:00:31 +0100 Subject: [PATCH 6/6] test name --- tests/test_http.py | 2 +- tests/test_robust.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/test_http.py b/tests/test_http.py index 917dbeb..2f8ef50 100644 --- a/tests/test_http.py +++ b/tests/test_http.py @@ -1,6 +1,6 @@ from multiurl.http import RETRIABLE -def test_retriable_is_list_of_strings(): +def test_retriable_is_list_or_tuple(): assert isinstance(RETRIABLE, (list, tuple)) diff --git a/tests/test_robust.py b/tests/test_robust.py index fab4dc7..0bbae94 100644 --- a/tests/test_robust.py +++ b/tests/test_robust.py @@ -37,7 +37,7 @@ def killer(): save.cancel() -def test_retriable_is_list_of_strings(): +def test_retriable_is_list_or_tuple(): assert isinstance(RETRIABLE, (list, tuple))