From d8036dbf974a37ce86112ddbcc0e7fff004cc3ac Mon Sep 17 00:00:00 2001 From: Joshua Igor Date: Sat, 3 Jul 2021 08:12:46 -0300 Subject: [PATCH 1/4] Added -UseBasicParsing MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Added -UseBasicParsing. This parameter is required when Internet Explorer is not installed on the computer.¹ Most Windows 10 machines will not have IE installed anymore, according to Microsoft² 1. https://docs.microsoft.com/de-de/powershell/module/Microsoft.PowerShell.Utility/Invoke-WebRequest?view=powershell-7.1&viewFallbackFrom=powershell-3.0 2. https://blogs.windows.com/windowsexperience/2021/05/19/the-future-of-internet-explorer-on-windows-10-is-in-microsoft-edge/ --- Functions/Update-GoogleDynamicDNS.ps1 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Functions/Update-GoogleDynamicDNS.ps1 b/Functions/Update-GoogleDynamicDNS.ps1 index 1d736e6..b880371 100644 --- a/Functions/Update-GoogleDynamicDNS.ps1 +++ b/Functions/Update-GoogleDynamicDNS.ps1 @@ -95,7 +95,7 @@ Function Update-GoogleDynamicDNS { } if ($PSCmdlet.ShouldProcess("$subAndDomain","Adding IP")) { - $response = Invoke-WebRequest -uri $webRequestURI -Method Post -Body $params -Credential $credential + $response = Invoke-WebRequest -uri $webRequestURI -UseBasicParsing -Method Post -Body $params -Credential $credential $Result = $Response.Content $StatusCode = $Response.StatusCode switch ($Result) { From e487f84650c2075633ecf32b9167ddf032e191c7 Mon Sep 17 00:00:00 2001 From: KAsp3rd Date: Fri, 20 May 2022 11:01:16 -0400 Subject: [PATCH 2/4] Update Update-GoogleDynamicDNS.ps1 Change the logic to allow for nested subdomains (i.e. store.district) and top level domains with more then 1 "." (i.e. company.co.uk; store.district.company.co.uk) --- Functions/Update-GoogleDynamicDNS.ps1 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Functions/Update-GoogleDynamicDNS.ps1 b/Functions/Update-GoogleDynamicDNS.ps1 index b880371..03a085a 100644 --- a/Functions/Update-GoogleDynamicDNS.ps1 +++ b/Functions/Update-GoogleDynamicDNS.ps1 @@ -74,14 +74,14 @@ Function Update-GoogleDynamicDNS { $params = @{} $splitDomain = $domainName.split(".") - if ($splitDomain.Length -ne 2) { + if ($splitDomain.Length -ge 2) { throw "Please enter a valid top-level domain name (yourdomain.tld)" } $subAndDomain = $subDomainName + "." + $domainName $splitDomain = $subAndDomain.split(".") - if ($splitDomain.Length -ne 3) { + if ($splitDomain.Length -ge 3) { throw "Please enter a valid host and domain name (subdomain.yourdomain.tld)" } From 573b8613196882c01d1aca1af4b39d8e1ecbfc6e Mon Sep 17 00:00:00 2001 From: KAsp3rd Date: Fri, 20 May 2022 11:13:46 -0400 Subject: [PATCH 3/4] Update Update-GoogleDynamicDNS.ps1 corrected "." count --- Functions/Update-GoogleDynamicDNS.ps1 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Functions/Update-GoogleDynamicDNS.ps1 b/Functions/Update-GoogleDynamicDNS.ps1 index 03a085a..dc4c223 100644 --- a/Functions/Update-GoogleDynamicDNS.ps1 +++ b/Functions/Update-GoogleDynamicDNS.ps1 @@ -74,14 +74,14 @@ Function Update-GoogleDynamicDNS { $params = @{} $splitDomain = $domainName.split(".") - if ($splitDomain.Length -ge 2) { + if ($splitDomain.Length -ge 1) { throw "Please enter a valid top-level domain name (yourdomain.tld)" } $subAndDomain = $subDomainName + "." + $domainName $splitDomain = $subAndDomain.split(".") - if ($splitDomain.Length -ge 3) { + if ($splitDomain.Length -ge 2) { throw "Please enter a valid host and domain name (subdomain.yourdomain.tld)" } From 14033210b54ffe03463efdf36eff553c02884fc0 Mon Sep 17 00:00:00 2001 From: KAsp3rd Date: Fri, 20 May 2022 11:46:21 -0400 Subject: [PATCH 4/4] Update Update-GoogleDynamicDNS.ps1 My brain really isn't functioning today... my logic was backwards from how it was intended. Corrected now --- Functions/Update-GoogleDynamicDNS.ps1 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Functions/Update-GoogleDynamicDNS.ps1 b/Functions/Update-GoogleDynamicDNS.ps1 index dc4c223..853a95b 100644 --- a/Functions/Update-GoogleDynamicDNS.ps1 +++ b/Functions/Update-GoogleDynamicDNS.ps1 @@ -74,14 +74,14 @@ Function Update-GoogleDynamicDNS { $params = @{} $splitDomain = $domainName.split(".") - if ($splitDomain.Length -ge 1) { + if ($splitDomain.Length -lt 1) { throw "Please enter a valid top-level domain name (yourdomain.tld)" } $subAndDomain = $subDomainName + "." + $domainName $splitDomain = $subAndDomain.split(".") - if ($splitDomain.Length -ge 2) { + if ($splitDomain.Length -lt 1) { throw "Please enter a valid host and domain name (subdomain.yourdomain.tld)" }