diff --git a/app/components/event_details_component.rb b/app/components/event_details_component.rb index 96416da2a..6696162a0 100644 --- a/app/components/event_details_component.rb +++ b/app/components/event_details_component.rb @@ -1,10 +1,6 @@ # Renders the detail list shown at the top of an event page. Admin: true adds # operator-only rows (user, timestamps, expiry). class EventDetailsComponent < ViewComponent::Base - def self.for(event, admin: false) - new(event: event, admin: admin) - end - def initialize(event:, admin: false) @event = event @admin = admin diff --git a/app/views/admin/events/show.html.erb b/app/views/admin/events/show.html.erb index 104309fc8..9ef2853bf 100644 --- a/app/views/admin/events/show.html.erb +++ b/app/views/admin/events/show.html.erb @@ -28,7 +28,7 @@ <%= render Admin::EventDescriptionComponent.for(@event) %> <% end %> - <%= render EventDetailsComponent.for(@event, admin: true) %> + <%= render EventDetailsComponent.new(event: @event, admin: true) %> <% if @referenced_posts.any? %>
diff --git a/app/views/events/show.html.erb b/app/views/events/show.html.erb index a12be1647..be5aee509 100644 --- a/app/views/events/show.html.erb +++ b/app/views/events/show.html.erb @@ -28,7 +28,7 @@ <%= render EventDescriptionComponent.for(@event) %> <% end %> - <%= render EventDetailsComponent.for(@event) %> + <%= render EventDetailsComponent.new(event: @event) %> <% if @referenced_posts.any? %>
diff --git a/test/components/event_details_component_test.rb b/test/components/event_details_component_test.rb index 40772f796..645d56784 100644 --- a/test/components/event_details_component_test.rb +++ b/test/components/event_details_component_test.rb @@ -10,16 +10,10 @@ def feed @feed ||= create(:feed, user: user, name: "Test Feed") end - test ".for should return the base component" do - event = create(:event, type: "generic_event") - - assert_instance_of EventDetailsComponent, EventDetailsComponent.for(event) - end - test "#call should render the created timestamp without admin extras" do event = create(:event, type: "owned_event", level: :warning, subject: feed) - result = render_inline(EventDetailsComponent.for(event)) + result = render_inline(EventDetailsComponent.new(event: event)) assert_includes result.to_html, "Created" assert_empty result.css('[data-key="admin.event.user"]') @@ -28,7 +22,7 @@ def feed test "#call should render a compact user link when admin" do event = create(:event, type: "owned_event", user: user, subject: feed) - result = render_inline(EventDetailsComponent.for(event, admin: true)) + result = render_inline(EventDetailsComponent.new(event: event, admin: true)) link = result.css("a[data-key='admin.event.user']").first assert_equal event.user_id.to_s.last(5), link.text