From 0f675f90af577fc5ee023cd8859675d37586c864 Mon Sep 17 00:00:00 2001 From: Parker Bibus Date: Thu, 11 Jun 2026 16:25:24 -0700 Subject: [PATCH] Clean up unused parameter and stray escape in upload template MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Two small unrelated cleanups in the BCS upload templates: 1) upload-build-artifacts-job.yml — drop the trailing backslash in the 'Upload Build Artifact …\\' job displayName. In YAML single-quoted strings, backslash is a literal character (only \''\ escapes a quote), so this currently renders in the AzDO UI as a stray 'Upload Build Artifact \\'. Removing it is purely cosmetic. 2) upload-build-artifacts-jobs.yml — remove the unused 'mauiFramework' template parameter. It was declared on the dispatcher but never referenced in the dispatcher body, and no current caller passes it to this template (dotnet/runtime's perf-build.yml passes mauiFramework only to runtime-perf-build-jobs.yml, not to upload-build-artifacts-jobs.yml). Safe to drop. Intentionally NOT removed: the 'runtimeRepoAlias' parameter on upload-build-artifacts-jobs.yml is also unused in the dispatcher body, but dotnet/runtime's perf-build.yml DOES pass it explicitly. Dropping it here would fail template expansion on the runtime side with 'Unexpected parameter ''runtimeRepoAlias'''. Cleaning that up requires a coordinated dotnet/runtime tenant update first and is left for a follow-up PR. No behavioral change for any current caller. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- eng/pipelines/templates/upload-build-artifacts-job.yml | 2 +- eng/pipelines/upload-build-artifacts-jobs.yml | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/eng/pipelines/templates/upload-build-artifacts-job.yml b/eng/pipelines/templates/upload-build-artifacts-job.yml index d5cfca201ae..594542b3f36 100644 --- a/eng/pipelines/templates/upload-build-artifacts-job.yml +++ b/eng/pipelines/templates/upload-build-artifacts-job.yml @@ -6,7 +6,7 @@ parameters: jobs: - ${{ each artifact in parameters.artifacts }}: - job: UploadBuildArtifact_${{ artifact.artifactName }} - displayName: 'Upload Build Artifact ${{ artifact.artifactName }}\' + displayName: 'Upload Build Artifact ${{ artifact.artifactName }}' condition: eq(stageDependencies.Build.${{ parameters.dependencyJobName }}.result, 'Succeeded') steps: - checkout: none diff --git a/eng/pipelines/upload-build-artifacts-jobs.yml b/eng/pipelines/upload-build-artifacts-jobs.yml index d734eecef78..c510e30f3db 100644 --- a/eng/pipelines/upload-build-artifacts-jobs.yml +++ b/eng/pipelines/upload-build-artifacts-jobs.yml @@ -2,7 +2,6 @@ parameters: runtimeRepoAlias: runtime performanceRepoAlias: self buildType: [] - mauiFramework: '' jobs: - ${{ if containsValue(parameters.buildType, 'coreclr_arm64_linux') }}: