Skip to content

[Feature Request] Composable function for Fullscreen { } #61

Description

@rvp-diconium

The code in BottomSheet.kt is very similar (most likely copy-paste-modified) from the android Dialog { } function.

Both those code have the base setup of getting LocalView, remember composition context, have a wrapper, with apply setContent with some type of DialogLayout or BottomSheetLayout. In the wrapper it sets view tree owner for several components. In the layout sets an ID with a tag with compose_view_saveable_id_tag.

This whole complex iteration could be also used by other developers on different layouts that are not just BottomSheet or Dialog, and that's the feature request.

If you could decouple BottomSheet from the underlying platform methods to create this full-screen UI function and expose it from your library like a @Composable fun Fullscreen { } might need some optional parameters like the onBackPress. The @Composable fun BottomSheet { } would use this Fullscreen.

[ I'll try to also add a feature request for that in the Android bug-tracker but we know it's less likely to be implemented (: ]

Thanks!

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions