From 08028a1c128bc51220a332c18b5d945f718a4f65 Mon Sep 17 00:00:00 2001 From: Jeremy Childs Date: Mon, 9 Jul 2012 11:15:41 -0600 Subject: [PATCH 1/6] Removed Close() calls for UDP. --- lib/manager.js | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/lib/manager.js b/lib/manager.js index 17912a8..fe9706a 100644 --- a/lib/manager.js +++ b/lib/manager.js @@ -165,9 +165,6 @@ function managerRetry(self, id) } else { delete(self._requests[id]); request.cb(1, {}); - - if (Object.keys(self._requests).length == 0) - self._dgram.close(); } } @@ -196,9 +193,6 @@ function managerRecv(self, buf, peer) nextBulkGet(self, options, msg.varBindList); break; } - - if (Object.keys(self._requests).length == 0) - self._dgram.close(); } /* API */ @@ -225,10 +219,6 @@ function Manager(options) function (err) { /* XXX */ }); this._dgram.bind(options.localport); - process.nextTick(function() { - if (Object.keys(self._requests).length == 0) - self._dgram.close(); - }); } Manager.prototype.get = function (agent, oids, cb, options) From 737a5f7db636284e54458c3ba88ad18e8d43fc81 Mon Sep 17 00:00:00 2001 From: Jeremy Childs Date: Mon, 9 Jul 2012 11:22:01 -0600 Subject: [PATCH 2/6] Update to >= 0.6 --- package.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/package.json b/package.json index dc5237c..cdcd69f 100644 --- a/package.json +++ b/package.json @@ -5,14 +5,14 @@ "version": "0.0.2", "repository": { "type": "git", - "url": "git://github.com/dgwynne/node-snmp.git" + "url": "git://github.com/jeremyc/node-snmp.git" }, "main": "lib/index.js", "directories": { "lib": "./lib" }, "engines": { - "node": ">=0.4" + "node": ">=0.6" }, "dependencies": { "asn1": "0.1.11", From 51c7fe42bb63bb40b0376ab15585dabe0ec9768d Mon Sep 17 00:00:00 2001 From: Jeremy Childs Date: Mon, 9 Jul 2012 15:20:32 -0600 Subject: [PATCH 3/6] Added close method. --- lib/manager.js | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/lib/manager.js b/lib/manager.js index fe9706a..57d5ddb 100644 --- a/lib/manager.js +++ b/lib/manager.js @@ -221,6 +221,14 @@ function Manager(options) this._dgram.bind(options.localport); } +Manager.prototype.close = function() { + try { + this._dgram.close(); + } catch(e) { + // ?? I don't think we care + } +} + Manager.prototype.get = function (agent, oids, cb, options) { if (typeof(agent) !== 'string') From 6567dd80be5be498207d92a9246ad5d1e5efdc5d Mon Sep 17 00:00:00 2001 From: Jeremy Childs Date: Mon, 9 Jul 2012 15:22:06 -0600 Subject: [PATCH 4/6] Updated package. --- package.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/package.json b/package.json index cdcd69f..20cbd19 100644 --- a/package.json +++ b/package.json @@ -2,10 +2,10 @@ "author": "David Gwynne ", "name": "snmp", "description": "SNMP APIs", - "version": "0.0.2", + "version": "0.0.3", "repository": { "type": "git", - "url": "git://github.com/jeremyc/node-snmp.git" + "url": "git://github.com/dgwynne/node-snmp.git" }, "main": "lib/index.js", "directories": { From d74959c5701aa1aeae9e0990d8475fb58c1405f7 Mon Sep 17 00:00:00 2001 From: Jeremy Childs Date: Thu, 29 Nov 2012 16:55:58 -0700 Subject: [PATCH 5/6] Update lib/messages/message.js BigNumber compat fix. --- lib/messages/message.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/messages/message.js b/lib/messages/message.js index 6130a43..cd63ffe 100644 --- a/lib/messages/message.js +++ b/lib/messages/message.js @@ -58,7 +58,7 @@ function parseInt(ber, tag) value = value.shiftLeft(8).add(a); } - return (fb & 0x80) ? value.mul(-1) : value; + return (fb & 0x80) ? value.multiply(-1) : value; } var intTypes = [ ASN1.Ber.Integer, 65, 66, 67, 70 ]; for (var i = 0; i < intTypes.length; i++) { From cf796acb7818525d099224c0647bc05aa58d84b1 Mon Sep 17 00:00:00 2001 From: Jeremy Childs Date: Fri, 30 Nov 2012 11:20:09 -0700 Subject: [PATCH 6/6] Update lib/messages/message.js Fixed two's compliment bug. There is likely a WAY better way of doing this, but I'm at a loss today. --- lib/messages/message.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/messages/message.js b/lib/messages/message.js index cd63ffe..66f89ee 100644 --- a/lib/messages/message.js +++ b/lib/messages/message.js @@ -58,7 +58,7 @@ function parseInt(ber, tag) value = value.shiftLeft(8).add(a); } - return (fb & 0x80) ? value.multiply(-1) : value; + return (fb & 0x80) ? value.subtract(BigInteger.valueOf(Math.pow(2,(buf.length*8)-1))) : value; } var intTypes = [ ASN1.Ber.Integer, 65, 66, 67, 70 ]; for (var i = 0; i < intTypes.length; i++) {