Skip to content

Different order of (estimates, reference) in SISDR Loss forward  #96

Description

@seastar105

while other metrics accept (estimates, reference) in function call, SISDR takes (reference, estimates) in function call which makes confusing and easy-to-mistake. need change!

def forward(self, x: AudioSignal, y: AudioSignal):
eps = 1e-8
# nb, nc, nt
if isinstance(x, AudioSignal):
references = x.audio_data
estimates = y.audio_data
else:
references = x
estimates = y

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions