fix: disconnect standup before navigating home#6040
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes the standup end-state "Back home" path so leaving an ended room performs an intentional disconnect before routing away.
Root cause
The ended-state CTA navigated away without explicitly tearing down the live-room connection first. That left a late websocket close or error event free to surface during navigation, which could produce a stray connection-related UI artifact after clicking back home.
Changes
disconnect()action to the live-room contextImpact
Closing a standup and clicking back home should now return to the home page without the weird follow-up toast or transient connection error state.
Validation
node ./scripts/typecheck-strict-changed.jspnpm --filter @dailydotdev/shared exec eslint src/contexts/LiveRoomContext.tsx src/components/liveRooms/LiveRoom.tsx src/components/liveRooms/LiveRoom.spec.tsx src/components/liveRooms/LiveRoomControls.spec.tsx --max-warnings 0NODE_ENV=test pnpm --filter @dailydotdev/shared exec jest src/components/liveRooms/LiveRoom.spec.tsx src/components/liveRooms/LiveRoomControls.spec.tsx src/contexts/LiveRoomContext.spec.tsx --runInBandPreview domain
https://codex-standup-ended-back-home-di.preview.app.daily.dev