Research more user friendly, graceful (non-fatal) ways for Encrypt Exceptions to be thrown

[nerdstein]

Exceptions are thrown when no key exists or requirements for encryption are not met.

This shouldn't throw a PHP fatal. This should log a message and possibly throw a site message.

[svendecabooter]

Shouldn't it be up to the consumer of the "encryption" service to catch the error that is being thrown, and add a message to the log and / or show an error on the website?

It seems to me like the current logic where \Drupal\encrypt\EncryptService throws exceptions is reasonable, although they could be made more specific, rather than just \Exception.

Though one can argue that maybe not all code using the encrypt() / decrypt() API methods will properly catch the errors, I don't think the Encrypt module can make assumptions as to how to visualise the error, since that might be different for different implementations of the service.

Perhaps better documentation about the types of errors that could be thrown by the service would be a better approach?

[nerdstein]

@svendecabooter I'm cool with that approach.

One of your PRs has EncryptionException - we can use that.

We should add an exception handling example to the readme so that we demonstrate proper use.

[svendecabooter]

Does this need extra work, or is the displaying of errors on the encryption profile overview (recently merged into master) enough?

The EncryptionProfile entity now has a validate method, which should be called before saving the entity to retrieve a list of errors. If not called, an exception will be thrown by the preSave() method of EncryptionProfile.

So any code that works with EncryptionProfile entities can first validate the entity, and provide the errors messages in a nice way (as the Encrypt module does as well on the overview page). In case the entity is not validated by the calling code, one would expect to have an error thrown.

Let me know if there are specific cases where a fatal error gets thrown, where a nice message would be better.