From 028442fdd7efcd9a1ae6ca7d3853c57a8e795252 Mon Sep 17 00:00:00 2001 From: Denes Sapi Date: Thu, 19 Jun 2025 11:56:17 +0200 Subject: [PATCH 1/3] fix: Remove unused constructor argument from transport implementations --- src/transport/dummy.js | 4 ++-- src/transport/http.js | 4 ++-- src/transport/ws.js | 4 ++-- src/trap.js | 2 +- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/transport/dummy.js b/src/transport/dummy.js index fd85db1..ad23db6 100644 --- a/src/transport/dummy.js +++ b/src/transport/dummy.js @@ -10,8 +10,8 @@ import Transport from './transport'; import simpleAutoBind from '../simpleAutoBind'; class Dummy extends Transport { - constructor(metadata, allowInMemoryBuffer) { - super(metadata, allowInMemoryBuffer); + constructor(metadata) { + super(metadata); simpleAutoBind(this); } diff --git a/src/transport/http.js b/src/transport/http.js index f848fe9..dc49858 100644 --- a/src/transport/http.js +++ b/src/transport/http.js @@ -12,8 +12,8 @@ import Transport from './transport'; import simpleAutoBind from '../simpleAutoBind'; class HTTP extends Transport { - constructor(metadata, allowInMemoryBuffer = false) { - super(metadata, allowInMemoryBuffer); + constructor(metadata) { + super(metadata); simpleAutoBind(this); } diff --git a/src/transport/ws.js b/src/transport/ws.js index 7d2ba66..a27f45c 100644 --- a/src/transport/ws.js +++ b/src/transport/ws.js @@ -10,8 +10,8 @@ import simpleAutoBind from '../simpleAutoBind'; import Transport from './transport'; class WS extends Transport { - constructor(metadata, logger, allowInMemoryBuffer = false) { - super(metadata, allowInMemoryBuffer); + constructor(metadata, logger) { + super(metadata); simpleAutoBind(this); this._logger = logger; diff --git a/src/trap.js b/src/trap.js index acea331..29ab715 100644 --- a/src/trap.js +++ b/src/trap.js @@ -69,7 +69,7 @@ class Trap { // Default logger sends logs to console // eslint-disable-next-line no-console logger: (...m) => { console.log(...m); }, - transport: new HTTP(this._metadata, this._buffer), + transport: new HTTP(this._metadata), sequenceNumber: 0, eventStorage: new InMemoryEventStorage(), collectEvents: false, From b1c527ab7b78637a97a1b632f4460a3ce5144f1a Mon Sep 17 00:00:00 2001 From: Denes Sapi Date: Thu, 19 Jun 2025 11:57:09 +0200 Subject: [PATCH 2/3] fix: Fix typing errors in JSDoc for Trap --- src/trap.js | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/trap.js b/src/trap.js index 29ab715..539204d 100644 --- a/src/trap.js +++ b/src/trap.js @@ -452,7 +452,7 @@ class Trap { /** * Set the buffer size limit for in-memory event collection * - * @param {int} sizeLimit + * @param {number} sizeLimit */ setEventCollectionSizeLimit(sizeLimit) { this.state.eventStorage.sizeLimit = sizeLimit; @@ -461,7 +461,7 @@ class Trap { /** * Set the metadata submission interval * - * @param {int} metadataSubmissionInterval + * @param {number} metadataSubmissionInterval */ setMetadataSubmissionInterval(metadataSubmissionInterval) { this._metadata.metadataSubmissionInterval = metadataSubmissionInterval; @@ -488,7 +488,7 @@ class Trap { /** * Enable / disable coalesced pointer event collection * - * @param {bool} capture + * @param {boolean} capture */ setCaptureCoalescedEvents(capture) { this._handlers.captureCoalescedEvents(capture); @@ -497,7 +497,7 @@ class Trap { /** * Enable / disable requestAnimationFrame message collection * - * @param {bool} capture + * @param {boolean} capture */ setCaptureRequestAnimationFrame(capture) { this.state.captureRequestAnimationFrame = capture; @@ -536,9 +536,9 @@ class Trap { * @deprecated use collectedEvents instead and do the filtering and counting * in the calling application. * - * @param {filterFunction} filterFn + * @param {function(Array):boolean} filterFn * - * @returns {int} + * @returns {number} */ collectedEventCount(filterFn = () => true) { return this.collectedEvents().filter(filterFn).length; @@ -567,7 +567,7 @@ class Trap { /** * Event handler when data is submitted by the transport layer. * - * @param {function(any[]):void} callback + * @param {(function(any[]):void) | undefined} callback */ onDataSubmitted(callback) { this.state.transport.off( From c2b4ee39900151f6e6c030d8217d6a4984da1ba5 Mon Sep 17 00:00:00 2001 From: Denes Sapi Date: Thu, 19 Jun 2025 11:57:51 +0200 Subject: [PATCH 3/3] chore: Upgrade version number to 1.0.22 --- package-lock.json | 4 ++-- package.json | 2 +- src/constants.js | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/package-lock.json b/package-lock.json index fbfebb2..ae2d56d 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,12 +1,12 @@ { "name": "ci-trap-web", - "version": "1.0.21", + "version": "1.0.22", "lockfileVersion": 2, "requires": true, "packages": { "": { "name": "ci-trap-web", - "version": "1.0.21", + "version": "1.0.22", "license": "MIT", "dependencies": { "fflate": "^0.8.0", diff --git a/package.json b/package.json index f15afe8..c601a35 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "ci-trap-web", - "version": "1.0.21", + "version": "1.0.22", "description": "Lightweight mouse and touch event tracker library for browsers.", "main": "dist/trap-umd.min.js", "module": "src/trap.js", diff --git a/src/constants.js b/src/constants.js index f16a240..379c62d 100644 --- a/src/constants.js +++ b/src/constants.js @@ -15,7 +15,7 @@ export const SCHEMA_VERSION = '1-0-0'; // This is updated by npm version command -export const PACKAGE_VERSION = '1.0.21'; +export const PACKAGE_VERSION = '1.0.22'; // Constants to define the current component in the schema export const PACKAGE_NAME = 'ci-trap-web';