Do not call functions from ExternalModules directly

[ChemiKyle]

See official documentation and issue.

Recommend something like sed s/ExternalModules::/$this->/g to correct but each line will need to be inspected.

[ChemiKyle]

This issue is going to be difficult. The following files:lines are affected:

grep -rn . -e 'ExternalModules::' | cut -f 1 -d " "

./classes/SchemaManagerPage.php:36:
./classes/SchemaManagerPage.php:156:
./classes/SchemaManagerPage.php:157:
./classes/EntityFactory.php:53:
./classes/EntityFactory.php:282:
./classes/EntityFactory.php:283:
./classes/EntityList.php:58:
./classes/EntityList.php:739:
./classes/EntityList.php:740:
./classes/EntityList.php:743:
./classes/EntityList.php:744:
./classes/EntityList.php:754:
./classes/EntityForm.php:27:
./classes/EntityForm.php:65:
./classes/EntityForm.php:66:
./classes/EntityForm.php:68:
./classes/EntityForm.php:69:
./classes/EntityForm.php:72:
./classes/EntityForm.php:73:
./classes/EntityDB.php:11:
./classes/EntityDB.php:25:
./ExternalModule.php:50:
./manager/entity.php:40:
./examples/protocols_advanced_v0.0.0/classes/ProtocolForm.php:18:
./examples/protocols_advanced_v0.0.0/classes/ProtocolForm.php:19:
./README-developer.md:686:
./README-developer.md:687:

The files in classes/ do not have access to the $module instantiation of the ExternalModule class, therefore they can not directly use the ExternalModules\AbstractExternalModule (the class whose methods Mark McEver indicates we should use over ExternalModules\ExternalModules) methods as simply as in other modules. This one may require a large refactor.

Additionally, some functions do not have AbstractExternalModule equivalents at all and cannot be replaced, e.g.

redcap_entity/classes/EntityFactory.php

Line 282 in 6b5d318

foreach (ExternalModules::getEnabledModules() as $prefix => $version) {

The nature of the latter function calls may be outside of the scope of the intent of this issue as they aren't intended to be safely wrapped by AbstractExternalModule, but may still be considered volatile given the philosophy of the ExternalModules\ExternalModules class.